Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2766633002: Use a blacklist instead of whitelist for cpplint (Closed)

Created:
3 years, 9 months ago by oprypin_webrtc
Modified:
3 years, 9 months ago
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Use a blacklist instead of whitelist for cpplint BUG=webrtc:5149 NOTRY=True Review-Url: https://codereview.webrtc.org/2766633002 Cr-Commit-Position: refs/heads/master@{#17355} Committed: https://chromium.googlesource.com/external/webrtc/+/2aa463f721c922ec93bdd3306650b0e24968b92d

Patch Set 1 : Use a blacklist instead of whitelist for cpplint #

Patch Set 2 : Final additions to blacklist that I missed before #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -30 lines) Patch
M PRESUBMIT.py View 1 3 chunks +41 lines, -30 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
oprypin_webrtc
3 years, 9 months ago (2017-03-23 09:29:16 UTC) #5
kjellander (google.com)
lgtm
3 years, 9 months ago (2017-03-23 09:36:30 UTC) #9
kjellander (google.com)
On 2017/03/23 09:36:30, kjellander (google.com) wrote: > lgtm Please let's not run all trybots for ...
3 years, 9 months ago (2017-03-23 09:37:35 UTC) #10
kjellander_webrtc
lgtm with the right account.
3 years, 9 months ago (2017-03-23 09:38:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2766633002/60001
3 years, 9 months ago (2017-03-23 10:14:32 UTC) #15
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 10:17:06 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/2aa463f721c922ec93bdd3306...

Powered by Google App Engine
This is Rietveld 408576698