Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtp_packet_history.cc

Issue 2766323006: Correcting the amount of padding when send side bwe includes RTP overhead.
Patch Set: another find Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtp_packet_history.cc
diff --git a/webrtc/modules/rtp_rtcp/source/rtp_packet_history.cc b/webrtc/modules/rtp_rtcp/source/rtp_packet_history.cc
index c4edc732b8fceb61b16c5323463e672f11593d17..58817ce33c03d5a0eb271c82c49e2c94f2bac14b 100644
--- a/webrtc/modules/rtp_rtcp/source/rtp_packet_history.cc
+++ b/webrtc/modules/rtp_rtcp/source/rtp_packet_history.cc
@@ -200,6 +200,8 @@ bool RtpPacketHistory::FindSeqNum(uint16_t sequence_number, int* index) const {
}
int RtpPacketHistory::FindBestFittingPacket(size_t size) const {
+ // TODO(minyue): it looks like that the fitting expects |size| to include
minyue-webrtc 2017/03/24 07:10:56 Philip and Stefan, would you take a look at this?
michaelt 2017/03/27 14:25:01 Looks wrong to me as well.
+ // headeer, but its use in RTPSender does not seem to match.
if (size < kMinPacketRequestBytes || stored_packets_.empty())
return -1;
size_t min_diff = std::numeric_limits<size_t>::max();
« no previous file with comments | « no previous file | webrtc/modules/rtp_rtcp/source/rtp_sender.cc » ('j') | webrtc/modules/rtp_rtcp/source/rtp_sender.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698