Correcting the amount of padding when send side bwe includes RTP overhead.

webrtc/modules/rtp_rtcp/source/rtp_packet_history.cc

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 182 matching lines @@
         temp_sequence_number = stored_packets_[*index].sequence_number;
         break;
       }
     }
   }
   return temp_sequence_number == sequence_number &&
          stored_packets_[*index].packet;
 }
 
 int RtpPacketHistory::FindBestFittingPacket(size_t size) const {
+  // TODO(minyue): it looks like that the fitting expects |size| to include

[minyue-webrtc, 2017/03/24 07:10:56]

Philip and Stefan, would you take a look at this?

[michaelt, 2017/03/27 14:25:01]

Looks wrong to me as well.

+  // headeer, but its use in RTPSender does not seem to match.
   if (size < kMinPacketRequestBytes || stored_packets_.empty())
     return -1;
   size_t min_diff = std::numeric_limits<size_t>::max();
   int best_index = -1;  // Returned unchanged if we don't find anything.
   for (size_t i = 0; i < stored_packets_.size(); ++i) {
     if (!stored_packets_[i].packet)
       continue;
     size_t stored_size = stored_packets_[i].packet->size();
     size_t diff =
         (stored_size > size) ? (stored_size - size) : (size - stored_size);
     if (diff < min_diff) {
       min_diff = diff;
       best_index = static_cast<int>(i);
     }
   }
   return best_index;
 }
 
 }  // namespace webrtc