Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2764753003: Reduce CPU usage in test::FrameGenerator::SquareGenerator. (Closed)

Created:
3 years, 9 months ago by perkj_webrtc
Modified:
3 years, 9 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reduce CPU usage in test::FrameGenerator::SquareGenerator. This cl change the drawing to use memset per row in each square instead of setting each pixel individually. BUG=webrtc:7380 Review-Url: https://codereview.webrtc.org/2764753003 Cr-Commit-Position: refs/heads/master@{#17339} Committed: https://chromium.googlesource.com/external/webrtc/+/c8b0865a2e52dcdfb70bd4e344893bae5c5d0aa1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M webrtc/test/frame_generator.cc View 1 chunk +10 lines, -8 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
perkj_webrtc
please?
3 years, 9 months ago (2017-03-21 20:22:34 UTC) #4
perkj_webrtc
please?
3 years, 9 months ago (2017-03-22 10:19:12 UTC) #8
kjellander_webrtc
rubberstamp lgtm for webrtc/test. Please wait for Stefan's review before submit.
3 years, 9 months ago (2017-03-22 10:40:49 UTC) #9
stefan-webrtc
lgtm
3 years, 9 months ago (2017-03-22 11:45:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2764753003/1
3 years, 9 months ago (2017-03-22 11:55:38 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-22 11:57:57 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/c8b0865a2e52dcdfb70bd4e34...

Powered by Google App Engine
This is Rietveld 408576698