Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2764403003: Skip audio_device_unittest when platform audio isn't used. (Closed)

Created:
3 years, 9 months ago by Max Morin WebRTC
Modified:
3 years, 9 months ago
Reviewers:
henrika_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, audio-team_agora.io, sdk-team_agora.io, peah-webrtc, kjellander_webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Skip audio_device_unittest when platform audio isn't used. BUG=webrtc:7393 Review-Url: https://codereview.webrtc.org/2764403003 Cr-Commit-Position: refs/heads/master@{#17359} Committed: https://chromium.googlesource.com/external/webrtc/+/33bf69ae6670e339f8bff8a723ef091f997c14a8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M webrtc/modules/audio_device/audio_device_unittest.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Max Morin WebRTC
henrika: PTAL. CC Kjellander.
3 years, 9 months ago (2017-03-23 09:32:59 UTC) #3
henrika_webrtc
lgtm
3 years, 9 months ago (2017-03-23 09:37:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2764403003/1
3 years, 9 months ago (2017-03-23 09:38:05 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_memcheck on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_memcheck/builds/6560)
3 years, 9 months ago (2017-03-23 10:30:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2764403003/1
3 years, 9 months ago (2017-03-23 10:42:12 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 11:06:57 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/33bf69ae6670e339f8bff8a72...

Powered by Google App Engine
This is Rietveld 408576698