Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 2763543002: Remove last mentions of speex from webrtc/modules (Closed)

Created:
3 years, 9 months ago by hlundin-webrtc
Modified:
3 years, 9 months ago
Reviewers:
the sun, perkj_webrtc
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove last mentions of speex from webrtc/modules BUG=webrtc:4844 Review-Url: https://codereview.webrtc.org/2763543002 Cr-Commit-Position: refs/heads/master@{#17309} Committed: https://chromium.googlesource.com/external/webrtc/+/ab980d0cb1bacab7c234a634b6a9a962c96db076

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -137 lines) Patch
M webrtc/modules/audio_coding/neteq/test/PayloadTypes.h View 1 chunk +3 lines, -46 lines 1 comment Download
M webrtc/modules/audio_coding/neteq/test/RTPencode.cc View 6 chunks +1 line, -88 lines 0 comments Download
M webrtc/modules/media_file/media_file_utility.h View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
hlundin-webrtc
PTAL perkj: webrtc/modules/media_file/media_file_utility.h solenberg: webrtc/modules/audio_coding/* https://codereview.webrtc.org/2763543002/diff/1/webrtc/modules/audio_coding/neteq/test/PayloadTypes.h File webrtc/modules/audio_coding/neteq/test/PayloadTypes.h (left): https://codereview.webrtc.org/2763543002/diff/1/webrtc/modules/audio_coding/neteq/test/PayloadTypes.h#oldcode16 webrtc/modules/audio_coding/neteq/test/PayloadTypes.h:16: #define NETEQ_CODEC_GSMFR_PT 3 FYI: ...
3 years, 9 months ago (2017-03-20 08:48:37 UTC) #2
the sun
lgtm
3 years, 9 months ago (2017-03-20 09:04:26 UTC) #3
perkj_webrtc
lgtm
3 years, 9 months ago (2017-03-20 11:26:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2763543002/1
3 years, 9 months ago (2017-03-20 12:34:47 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-20 12:56:30 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/ab980d0cb1bacab7c234a634b...

Powered by Google App Engine
This is Rietveld 408576698