MB: Add --quick flag for low_bandwidth_audio_test

MB: Add --quick flag for low_bandwidth_audio_test

This seems to be the preferred way to pass flags to tests running on Swarming.

Add --quick flag to the low_bandwidth_audio_test and support for 'args' keyword
(similar to upstream Chromium's mb.py).
Change the type of the test to non_parallel_console_test_launcher to avoid
running with gtest-parallel, since it will swallow the stdout output.

BUG=webrtc:7229
NOTRY=True
TBR=ehmaldonado@webrtc.org

Review-Url: https://codereview.webrtc.org/2763323003
Cr-Commit-Position: refs/heads/master@{#17353}
Committed: https://chromium.googlesource.com/external/webrtc/+/74e8126ac9be3653db578c6e355711d7566b1ce6

[kjellander_webrtc, 2017-03-22 15:17:15]

Description was changed from

==========
MB: Add --quick flag for low_bandwidth_audio_test

It turns out this is the only way to pass flags to
swarming binaries.

BUG=webrtc:7229
NOTRY=True
==========

to

==========
MB: Add --quick flag for low_bandwidth_audio_test

It turns out this is the only way to pass flags to
swarming binaries.

BUG=webrtc:7229
NOTRY=True
==========

[kjellander_webrtc, 2017-03-22 15:17:15]

kjellander@webrtc.org changed reviewers:
+ ehmaldonado@webrtc.org

[kjellander_webrtc, 2017-03-22 15:17:37]

Edward, what is a command line that can be used to test that this actually works
on swarming before deploying it on the bots?

[ehmaldonado_webrtc, 2017-03-22 15:29:16]

On 2017/03/22 15:17:37, kjellander_webrtc wrote:
> Edward, what is a command line that can be used to test that this actually
works
> on swarming before deploying it on the bots?

Example with modules_unittests in out/gn for linux

$ tools-webrtc/mb/mb.py isolate //out/gn modules_unittests
$ tools/swarming_client/isolate.py archive   -I
https://isolateserver.appspot.com   -i out/gn/modules_unittests.isolate   -s
out/gn/modules_unittests.isolated
$ tools/swarming_client/swarming.py trigger   -S
https://chromium-swarm.appspot.com   -I https://isolateserver.appspot.com   -d
pool Chrome -d os Linux -d cpu x86-64   out/gn/modules_unittests.isolated

For android, this instead of the third line

$ tools/swarming_client/swarming.py trigger   -S
https://chromium-swarm.appspot.com   -I https://isolateserver.appspot.com   -d
pool Chrome -d os Android -d device_os M -d device_type bullhead  
out/gn/modules_unittests.isolated

[ehmaldonado_webrtc, 2017-03-22 15:29:35]

On 2017/03/22 15:29:16, ehmaldonado_webrtc wrote:
> On 2017/03/22 15:17:37, kjellander_webrtc wrote:
> > Edward, what is a command line that can be used to test that this actually
> works
> > on swarming before deploying it on the bots?
> 
> Example with modules_unittests in out/gn for linux
> 
> $ tools-webrtc/mb/mb.py isolate //out/gn modules_unittests
> $ tools/swarming_client/isolate.py archive   -I
> https://isolateserver.appspot.com   -i out/gn/modules_unittests.isolate   -s
> out/gn/modules_unittests.isolated
> $ tools/swarming_client/swarming.py trigger   -S
> https://chromium-swarm.appspot.com   -I https://isolateserver.appspot.com   -d
> pool Chrome -d os Linux -d cpu x86-64   out/gn/modules_unittests.isolated
> 
> For android, this instead of the third line
> 
> $ tools/swarming_client/swarming.py trigger   -S
> https://chromium-swarm.appspot.com   -I https://isolateserver.appspot.com   -d
> pool Chrome -d os Android -d device_os M -d device_type bullhead  
> out/gn/modules_unittests.isolated

Also, are you sure about that being the only way to pass flags to the swarming
binaries?

[kjellander_webrtc, 2017-03-23 07:35:23]

Description was changed from

==========
MB: Add --quick flag for low_bandwidth_audio_test

It turns out this is the only way to pass flags to
swarming binaries.

BUG=webrtc:7229
NOTRY=True
==========

to

==========
MB: Add --quick flag for low_bandwidth_audio_test

This seems to be the preferred way to pass flags to tests running on Swarming.

Add --quick flag to the low_bandwidth_audio_test and support for 'args' keyword
(similar to upstream Chromium's mb.py).
Change the type of the test to non_parallel_console_test_launcher to avoid
running with gtest-parallel, since it will swallow the stdout output.

BUG=webrtc:7229
NOTRY=True
TBR=ehmaldonado@webrtc.org
==========

[kjellander_webrtc, 2017-03-23 07:48:33]

The CQ bit was checked by kjellander@webrtc.org

[commit-bot: I haz the power, 2017-03-23 07:48:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-23 07:51:12]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490255313311810,
"parent_rev": "b0bf93a4b7cddbc70ef7468394852968e2bdbc3f", "commit_rev":
"74e8126ac9be3653db578c6e355711d7566b1ce6"}

[commit-bot: I haz the power, 2017-03-23 07:51:13]

Description was changed from

==========
MB: Add --quick flag for low_bandwidth_audio_test

This seems to be the preferred way to pass flags to tests running on Swarming.

Add --quick flag to the low_bandwidth_audio_test and support for 'args' keyword
(similar to upstream Chromium's mb.py).
Change the type of the test to non_parallel_console_test_launcher to avoid
running with gtest-parallel, since it will swallow the stdout output.

BUG=webrtc:7229
NOTRY=True
TBR=ehmaldonado@webrtc.org
==========

to

==========
MB: Add --quick flag for low_bandwidth_audio_test

This seems to be the preferred way to pass flags to tests running on Swarming.

Add --quick flag to the low_bandwidth_audio_test and support for 'args' keyword
(similar to upstream Chromium's mb.py).
Change the type of the test to non_parallel_console_test_launcher to avoid
running with gtest-parallel, since it will swallow the stdout output.

BUG=webrtc:7229
NOTRY=True
TBR=ehmaldonado@webrtc.org

Review-Url: https://codereview.webrtc.org/2763323003
Cr-Commit-Position: refs/heads/master@{#17353}
Committed:
https://chromium.googlesource.com/external/webrtc/+/74e8126ac9be3653db578c6e3...
==========

[commit-bot: I haz the power, 2017-03-23 07:51:14]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/74e8126ac9be3653db578c6e3...