DCHECK that no RTPPayloadRegistry instance is used for both audio and video

DCHECK that no RTPPayloadRegistry instance is used for both audio and video

BUG=webrtc:5805
Review-Url: https://codereview.webrtc.org/2763323002
Cr-Commit-Position: refs/heads/master@{#17352}
Committed: https://chromium.googlesource.com/external/webrtc/+/b0bf93a4b7cddbc70ef7468394852968e2bdbc3f

[kwiberg-webrtc, 2017-03-22 14:05:49]

The CQ bit was checked by kwiberg@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 14:05:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[kwiberg-webrtc, 2017-03-22 14:11:42]

kwiberg@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org, mflodman@webrtc.org, solenberg@webrtc.org

[the sun, 2017-03-22 14:28:01]

lgtm

https://codereview.webrtc.org/2763323002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtp_payload_registry.cc (right):

https://codereview.webrtc.org/2763323002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtp_payload_registry.cc:133: rtc::CritScope
cs(&crit_sect_);
My only concern would be whether this class is raceful, and you need to do the
above check while holding the lock?

[commit-bot: I haz the power, 2017-03-22 14:28:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 14:28:22]

Dry run: Try jobs failed on following builders:
  linux_more_configs on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_more_configs/buil...)

[kwiberg-webrtc, 2017-03-22 17:46:42]

https://codereview.webrtc.org/2763323002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtp_payload_registry.cc (right):

https://codereview.webrtc.org/2763323002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtp_payload_registry.cc:133: rtc::CritScope
cs(&crit_sect_);
On 2017/03/22 14:28:01, the sun wrote:
> My only concern would be whether this class is raceful, and you need to do the
> above check while holding the lock?

Good point. I'll do that.

[kwiberg-webrtc, 2017-03-22 18:16:21]

The CQ bit was checked by kwiberg@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 18:16:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-22 18:39:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 18:39:24]

Dry run: This issue passed the CQ dry run.

[hlundin-webrtc, 2017-03-23 07:07:17]

lgtm

[kwiberg-webrtc, 2017-03-23 07:07:47]

The CQ bit was checked by kwiberg@webrtc.org

[kwiberg-webrtc, 2017-03-23 07:07:48]

The patchset sent to the CQ was uploaded after l-g-t-m from solenberg@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2763323002/#ps20001 (title:
"We ♥ locks!")

[commit-bot: I haz the power, 2017-03-23 07:07:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-23 07:10:09]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490252867861670,
"parent_rev": "65cb53a5c670d3aa1091f1fabf1d8b443e331296", "commit_rev":
"b0bf93a4b7cddbc70ef7468394852968e2bdbc3f"}

[commit-bot: I haz the power, 2017-03-23 07:10:12]

Description was changed from

==========
DCHECK that no RTPPayloadRegistry instance is used for both audio and video

BUG=webrtc:5805
==========

to

==========
DCHECK that no RTPPayloadRegistry instance is used for both audio and video

BUG=webrtc:5805

Review-Url: https://codereview.webrtc.org/2763323002
Cr-Commit-Position: refs/heads/master@{#17352}
Committed:
https://chromium.googlesource.com/external/webrtc/+/b0bf93a4b7cddbc70ef746839...
==========

[commit-bot: I haz the power, 2017-03-23 07:10:14]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/b0bf93a4b7cddbc70ef746839...