Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2763023002: Propagate input capture time in ViEEncoder::OnFrame. (Closed)

Created:
3 years, 9 months ago by nisse-webrtc
Modified:
3 years, 6 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Propagate input capture time in ViEEncoder::OnFrame. BUG=webrtc:6977 Review-Url: https://codereview.webrtc.org/2763023002 Cr-Commit-Position: refs/heads/master@{#18351} Committed: https://chromium.googlesource.com/external/webrtc/+/01d5a0b48d04f1d6cd8aee40d6e064a3d479f991

Patch Set 1 #

Patch Set 2 : Rebased. #

Patch Set 3 : Update frame generators to set timestamp. #

Patch Set 4 : Undo change to FrameGenerators, only FrameGeneratorCapturer need to set timestamp. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M webrtc/modules/video_coding/generic_encoder.cc View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M webrtc/test/frame_generator_capturer.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/video/vie_encoder.cc View 1 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
nisse-webrtc
PTAL, this fixes an old TODO from earlier timestamp refactoring.
3 years, 6 months ago (2017-05-29 13:11:00 UTC) #6
stefan-webrtc
How sure are we that this is safe with for instance the problematic logitech cameras ...
3 years, 6 months ago (2017-05-30 09:48:13 UTC) #7
nisse-webrtc
On 2017/05/30 09:48:13, stefan-webrtc wrote: > How sure are we that this is safe with ...
3 years, 6 months ago (2017-05-30 10:45:47 UTC) #8
stefan-webrtc
lgtm We should monitor the av sync stats to ensure that this doesn't cause issues.
3 years, 6 months ago (2017-05-31 13:27:14 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2763023002/60001
3 years, 6 months ago (2017-05-31 13:31:05 UTC) #15
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 13:33:27 UTC) #18
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/01d5a0b48d04f1d6cd8aee40d...

Powered by Google App Engine
This is Rietveld 408576698