third_party/WebKit/Source/web/WebPagePopupImpl.cpp - Issue 2762423003: Made Frame constructors (and subclasses) take Page& instead of Page*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebPagePopupImpl.cpp

Issue 2762423003: Made Frame constructors (and subclasses) take Page& instead of Page* (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebPagePopupImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebPagePopupImpl.cpp b/third_party/WebKit/Source/web/WebPagePopupImpl.cpp

index defe1a1b0fc2ba06d2743742263eabb2b12ef3e3..20792f98de7299cd43c2e589eced2f4b2e4fddde 100644

--- a/third_party/WebKit/Source/web/WebPagePopupImpl.cpp

+++ b/third_party/WebKit/Source/web/WebPagePopupImpl.cpp

@@ -307,7 +307,7 @@ bool WebPagePopupImpl::initializePage() {

provideContextFeaturesTo(*m_page, WTF::makeUnique<PagePopupFeaturesClient>());

DEFINE_STATIC_LOCAL(LocalFrameClient, emptyLocalFrameClient,

(EmptyLocalFrameClient::create()));

- LocalFrame* frame = LocalFrame::create(&emptyLocalFrameClient, m_page, 0);

+ LocalFrame* frame = LocalFrame::create(&emptyLocalFrameClient, *m_page, 0);

frame->setPagePopupOwner(m_popupClient->ownerElement());

frame->setView(FrameView::create(*frame));

frame->init();