Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(972)

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 2762423003: Made Frame constructors (and subclasses) take Page& instead of Page* (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
index 9ce0a57f847cedca63b206d3d3bf2b452633b83d..557c9218343a68a721d364a90b87aed029ee67e1 100644
--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
@@ -1525,7 +1525,7 @@ WebLocalFrameImpl* WebLocalFrameImpl::createProvisional(
// TODO(dcheng): This block is very similar to initializeCoreFrame. Try to
// reuse it here.
LocalFrame* frame = LocalFrame::create(webFrame->m_localFrameClientImpl.get(),
- oldFrame->page(), tempOwner,
+ *oldFrame->page(), tempOwner,
interfaceProvider, interfaceRegistry);
frame->tree().setName(
toWebRemoteFrameImpl(oldWebFrame)->frame()->tree().name());
@@ -1601,7 +1601,7 @@ void WebLocalFrameImpl::setCoreFrame(LocalFrame* frame) {
void WebLocalFrameImpl::initializeCoreFrame(Page& page,
FrameOwner* owner,
const AtomicString& name) {
- setCoreFrame(LocalFrame::create(m_localFrameClientImpl.get(), &page, owner,
+ setCoreFrame(LocalFrame::create(m_localFrameClientImpl.get(), page, owner,
m_interfaceProvider, m_interfaceRegistry));
frame()->tree().setName(name);
// We must call init() after m_frame is assigned because it is referenced
« no previous file with comments | « third_party/WebKit/Source/web/InspectorOverlay.cpp ('k') | third_party/WebKit/Source/web/WebPagePopupImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698