third_party/WebKit/Source/core/testing/DummyPageHolder.cpp - Issue 2762423003: Made Frame constructors (and subclasses) take Page& instead of Page*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/testing/DummyPageHolder.cpp

Issue 2762423003: Made Frame constructors (and subclasses) take Page& instead of Page* (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/testing/DummyPageHolder.cpp

diff --git a/third_party/WebKit/Source/core/testing/DummyPageHolder.cpp b/third_party/WebKit/Source/core/testing/DummyPageHolder.cpp

index b8e5a95c137cedaf8a16dfd283bf7c457b52c890..b2a1d0235e0ad5399ac21db93c32d836f8e170bb 100644

--- a/third_party/WebKit/Source/core/testing/DummyPageHolder.cpp

+++ b/third_party/WebKit/Source/core/testing/DummyPageHolder.cpp

@@ -80,7 +80,7 @@ DummyPageHolder::DummyPageHolder(const IntSize& initialViewSize,

if (!m_localFrameClient)

m_localFrameClient = EmptyLocalFrameClient::create();

- m_frame = LocalFrame::create(m_localFrameClient.get(), m_page, nullptr,

+ m_frame = LocalFrame::create(m_localFrameClient.get(), *m_page, nullptr,

interfaceProvider);

m_frame->setView(FrameView::create(*m_frame, initialViewSize));

m_frame->view()->page()->visualViewport().setSize(initialViewSize);