third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp - Issue 2762423003: Made Frame constructors (and subclasses) take Page& instead of Page*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp

Issue 2762423003: Made Frame constructors (and subclasses) take Page& instead of Page* (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp

diff --git a/third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp b/third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp

index 064b9010b8c720d2e889a505fd3fa2f6b185da58..9b97da95c461617574f213b068782412b760826c 100644

--- a/third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp

+++ b/third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp

@@ -675,7 +675,7 @@ Image::SizeAvailability SVGImage::dataChanged(bool allDataReceived) {

LocalFrame* frame = nullptr;

{

TRACE_EVENT0("blink", "SVGImage::dataChanged::createFrame");

- frame = LocalFrame::create(&dummyLocalFrameClient, page, 0);

+ frame = LocalFrame::create(&dummyLocalFrameClient, *page, 0);

frame->setView(FrameView::create(*frame));

frame->init();

}