Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 2762153002: Don't expect factory to create iLBC decoder if it isn't supported (Closed)

Created:
3 years, 9 months ago by kwiberg-webrtc
Modified:
3 years, 9 months ago
Reviewers:
ossu, kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Don't expect factory to create iLBC decoder if it isn't supported BUG=webrtc:7377 Review-Url: https://codereview.webrtc.org/2762153002 Cr-Commit-Position: refs/heads/master@{#17328} Committed: https://chromium.googlesource.com/external/webrtc/+/14325edfe408603948c8becbe3bff7d6252b6659

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M webrtc/modules/audio_coding/codecs/builtin_audio_decoder_factory_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
kwiberg-webrtc
3 years, 9 months ago (2017-03-21 13:13:33 UTC) #4
kwiberg-webrtc
3 years, 9 months ago (2017-03-21 14:24:50 UTC) #8
kjellander_webrtc
lgtm
3 years, 9 months ago (2017-03-21 14:32:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2762153002/1
3 years, 9 months ago (2017-03-21 19:14:18 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 19:17:03 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/14325edfe408603948c8becbe...

Powered by Google App Engine
This is Rietveld 408576698