Don't recalculate Tl0PicIdx when the VP9 frame has no Tl0PicIdx.

Don't recalculate Tl0PicIdx when the VP9 frame has no Tl0PicIdx.

BUG=webrtc:7362
Review-Url: https://codereview.webrtc.org/2760893002
Cr-Commit-Position: refs/heads/master@{#17311}
Committed: https://chromium.googlesource.com/external/webrtc/+/aff5be35e060a3d6ec6af506916fb0e2e03b8b00

[philipel, 2017-03-20 14:10:52]

philipel@webrtc.org changed reviewers:
+ stefan@webrtc.org

[tommi (sloooow) - chröme, 2017-03-20 14:15:27]

thanks for fixing drive by lgtm (although I'm not a reviewer)

https://codereview.webrtc.org/2760893002/diff/1/webrtc/modules/video_coding/r...
File webrtc/modules/video_coding/rtp_frame_reference_finder_unittest.cc (right):

https://codereview.webrtc.org/2760893002/diff/1/webrtc/modules/video_coding/r...
webrtc/modules/video_coding/rtp_frame_reference_finder_unittest.cc:1306: {
is there a reason for these scopes? (InsertPacket() doesn't seem to need it and
the unique_ptr is moved)

[philipel, 2017-03-20 14:29:37]

The CQ bit was checked by philipel@webrtc.org

[commit-bot: I haz the power, 2017-03-20 14:29:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-20 14:36:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 14:36:15]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/15129)

[philipel, 2017-03-20 14:38:49]

https://codereview.webrtc.org/2760893002/diff/1/webrtc/modules/video_coding/r...
File webrtc/modules/video_coding/rtp_frame_reference_finder_unittest.cc (right):

https://codereview.webrtc.org/2760893002/diff/1/webrtc/modules/video_coding/r...
webrtc/modules/video_coding/rtp_frame_reference_finder_unittest.cc:1306: {
On 2017/03/20 14:15:27, tommi - chröme wrote:
> is there a reason for these scopes? (InsertPacket() doesn't seem to need it
and
> the unique_ptr is moved)

Not really necessary but it made it easier to copy paste an
insert-frame-into-reference-finder code block instead of having frame1, frame2,
frame3...

[tommi, 2017-03-20 16:33:20]

tommi@webrtc.org changed reviewers:
+ tommi@webrtc.org

[tommi, 2017-03-20 16:33:21]

lgtm

https://codereview.webrtc.org/2760893002/diff/1/webrtc/modules/video_coding/r...
File webrtc/modules/video_coding/rtp_frame_reference_finder_unittest.cc (right):

https://codereview.webrtc.org/2760893002/diff/1/webrtc/modules/video_coding/r...
webrtc/modules/video_coding/rtp_frame_reference_finder_unittest.cc:1306: {
On 2017/03/20 14:38:49, philipel wrote:
> On 2017/03/20 14:15:27, tommi - chröme wrote:
> > is there a reason for these scopes? (InsertPacket() doesn't seem to need it
> and
> > the unique_ptr is moved)
> 
> Not really necessary but it made it easier to copy paste an
> insert-frame-into-reference-finder code block instead of having frame1,
frame2,
> frame3...

I see. Another alternative could of course be:

ref_packet_buffer_->InsertPacket(&packet);
reference_finder_->ManageFrame(
    std::unique_ptr<RtpFrameObject>(
        new RtpFrameObject(ref_packet_buffer_, 0, 0, 0, 0, 0)));

[philipel, 2017-03-20 16:37:30]

The CQ bit was checked by philipel@webrtc.org

[philipel, 2017-03-20 16:37:30]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@webrtc.org,
tommi@chromium.org
Link to the patchset: https://codereview.webrtc.org/2760893002/#ps20001 (title:
"Feedback fix + minor refactoring.")

[commit-bot: I haz the power, 2017-03-20 16:37:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-20 17:42:13]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490027850118930,
"parent_rev": "c55f27afa4530501aa96dfee839e092723858935", "commit_rev":
"aff5be35e060a3d6ec6af506916fb0e2e03b8b00"}

[commit-bot: I haz the power, 2017-03-20 17:42:17]

Description was changed from

==========
Don't recalculate Tl0PicIdx when the VP9 frame has no Tl0PicIdx.

BUG=webrtc:7362
==========

to

==========
Don't recalculate Tl0PicIdx when the VP9 frame has no Tl0PicIdx.

BUG=webrtc:7362

Review-Url: https://codereview.webrtc.org/2760893002
Cr-Commit-Position: refs/heads/master@{#17311}
Committed:
https://chromium.googlesource.com/external/webrtc/+/aff5be35e060a3d6ec6af5069...
==========

[commit-bot: I haz the power, 2017-03-20 17:42:18]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/aff5be35e060a3d6ec6af5069...