Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 2760613002: Delete unused method VideoCodingModule::DiscardedPackets(). (Closed)

Created:
3 years, 9 months ago by tommi
Modified:
3 years, 9 months ago
Reviewers:
philipel
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete unused method VideoCodingModule::DiscardedPackets(). This method isn't called and the value it represents, is made available via the stats APIs. BUG=none Review-Url: https://codereview.webrtc.org/2760613002 Cr-Commit-Position: refs/heads/master@{#17287} Committed: https://chromium.googlesource.com/external/webrtc/+/05e908b10bb32869c41dc96f980a2fbeae208f16

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -20 lines) Patch
M webrtc/modules/video_coding/include/video_coding.h View 1 chunk +0 lines, -6 lines 0 comments Download
M webrtc/modules/video_coding/receiver.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/receiver.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/modules/video_coding/video_coding_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/video_coding_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/modules/video_coding/video_receiver.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
tommi
3 years, 9 months ago (2017-03-17 10:40:57 UTC) #2
philipel
lgtm One of the tasks I have planned is to clean up after the old ...
3 years, 9 months ago (2017-03-17 11:58:07 UTC) #7
tommi
On 2017/03/17 11:58:07, philipel wrote: > lgtm > > One of the tasks I have ...
3 years, 9 months ago (2017-03-17 12:45:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2760613002/1
3 years, 9 months ago (2017-03-17 12:46:12 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 12:48:28 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/05e908b10bb32869c41dc96f9...

Powered by Google App Engine
This is Rietveld 408576698