Delete unused member RTCPSender::FeedbackState::send_payload_type.

Delete unused member RTCPSender::FeedbackState::send_payload_type.

It became unused with cl https://codereview.webrtc.org/2746413003/

BUG=webrtc:7338
Review-Url: https://codereview.webrtc.org/2759433005
Cr-Commit-Position: refs/heads/master@{#17293}
Committed: https://chromium.googlesource.com/external/webrtc/+/40ba3addc74aa1ddc7b964a622ced38ead154a8d

[nisse-webrtc, 2017-03-17 09:39:04]

nisse@webrtc.org changed reviewers:
+ danilchap@webrtc.org, stefan@webrtc.org

[nisse-webrtc, 2017-03-17 09:39:04]

PTAL. 

It's a bit unclear to me how RTPSender::payload_type_ is used. The accessors
RTPSender::SendPayloadType and SetSendPayloadType appear unused (except for test
code). Can they be deleted too?

[danilchap, 2017-03-17 09:43:16]

lgtm

https://codereview.webrtc.org/2759433005/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc (left):

https://codereview.webrtc.org/2759433005/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc:321: state.send_payload_type =
rtp_sender_.SendPayloadType();
may be delete RtpSender::SendPayloadType/SetSendPayloadType too
(RtpSender::payload_type_ still used though.)

[danilchap, 2017-03-17 09:45:29]

https://codereview.webrtc.org/2759433005/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc (left):

https://codereview.webrtc.org/2759433005/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc:321: state.send_payload_type =
rtp_sender_.SendPayloadType();
On 2017/03/17 09:43:15, danilchap wrote:
> may be delete RtpSender::SendPayloadType/SetSendPayloadType too
> (RtpSender::payload_type_ still used though.)

sorry, SetSendPayloadType actually still used, better keep it.

[Get]SendPayloadType is not used now.

[nisse-webrtc, 2017-03-17 09:54:55]

On 2017/03/17 09:43:16, danilchap wrote:
> lgtm
> 
>
https://codereview.webrtc.org/2759433005/diff/1/webrtc/modules/rtp_rtcp/sourc...
> File webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc (left):
> 
>
https://codereview.webrtc.org/2759433005/diff/1/webrtc/modules/rtp_rtcp/sourc...
> webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc:321: state.send_payload_type =
> rtp_sender_.SendPayloadType();
> may be delete RtpSender::SendPayloadType/SetSendPayloadType too
> (RtpSender::payload_type_ still used though.)

Hmm. SetSendPayloadType is used in CheckPayloadType (where it's easily replaced
by direct access), and in the test code.

It's not obvious to me, at a first look, what's the purpose of CheckPayloadType.
It's called by SendOutgoingData,
which gets a payload_type as argument. So I guess it's doing some sanity check,
and then caching the latest used payload 
type in |payload_type_|?  

In this cl, I can delete the getter method, and add a TODO item on the setter
method. But I don't feel like
refactoring the test code at the moment.

[nisse-webrtc, 2017-03-17 10:31:03]

New patchset, deleting the getter method.

[danilchap, 2017-03-17 11:11:49]

still lgtm

[nisse-webrtc, 2017-03-17 11:42:36]

The CQ bit was checked by nisse@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 11:42:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-17 12:05:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 12:05:23]

Dry run: This issue passed the CQ dry run.

[stefan-webrtc, 2017-03-17 13:16:27]

lgtm

[nisse-webrtc, 2017-03-17 14:00:24]

The CQ bit was checked by nisse@webrtc.org

[commit-bot: I haz the power, 2017-03-17 14:00:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-17 14:04:01]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489759224354840,
"parent_rev": "3b941bef7a95620ed69b097c0b2bd77b0c722c90", "commit_rev":
"40ba3addc74aa1ddc7b964a622ced38ead154a8d"}

[commit-bot: I haz the power, 2017-03-17 14:04:03]

Description was changed from

==========
Delete unused member RTCPSender::FeedbackState::send_payload_type.

It became unused with cl https://codereview.webrtc.org/2746413003/

BUG=webrtc:7338
==========

to

==========
Delete unused member RTCPSender::FeedbackState::send_payload_type.

It became unused with cl https://codereview.webrtc.org/2746413003/

BUG=webrtc:7338

Review-Url: https://codereview.webrtc.org/2759433005
Cr-Commit-Position: refs/heads/master@{#17293}
Committed:
https://chromium.googlesource.com/external/webrtc/+/40ba3addc74aa1ddc7b964a62...
==========

[commit-bot: I haz the power, 2017-03-17 14:04:04]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/40ba3addc74aa1ddc7b964a62...