Add MakeUnique from chromium and change StunMessage::AddAttribute to take a unique_ptr.

Add MakeUnique from chromium and change StunMessage::AddAttribute to take a unique_ptr.

BUG=NONE

Review-Url: https://codereview.webrtc.org/2757893003
Cr-Commit-Position: refs/heads/master@{#17403}
Committed: https://chromium.googlesource.com/external/webrtc/+/f42cc9d8d968f9a7483967a6d2de9c8e25c64474

[Zach Stein, 2017-03-23 17:59:20]

Description was changed from

==========
Add MakeUnique from chromium and change StunMessage::AddAttribute to take a
unique_ptr.

BUG=
==========

to

==========
Add MakeUnique from chromium and change StunMessage::AddAttribute to take a
unique_ptr.

BUG=NONE
==========

[Zach Stein, 2017-03-23 18:03:09]

zstein@webrtc.org changed reviewers:
+ deadbeef@webrtc.org

[Zach Stein, 2017-03-23 18:03:45]

Please take a look :)

[kwiberg-webrtc, 2017-03-23 21:45:54]

kwiberg@webrtc.org changed reviewers:
+ kwiberg@webrtc.org

[kwiberg-webrtc, 2017-03-23 21:45:55]

lgtm for webrtc/base/, provided that you add ptr_util.h to rtc_base_approved

https://codereview.webrtc.org/2757893003/diff/20001/webrtc/base/BUILD.gn
File webrtc/base/BUILD.gn (right):

https://codereview.webrtc.org/2757893003/diff/20001/webrtc/base/BUILD.gn#newc...
webrtc/base/BUILD.gn:853: "ptr_util_unittest.cc",
Please also add ptr_util.h to a build target. rtc_base_approved is probably the
right one.

[Zach Stein, 2017-03-27 21:00:31]

Can you take a look at the changes in p2p Taylor?

[Taylor Brandstetter, 2017-03-27 22:12:28]

p2p changes lgtm. Thanks for doing this! It's nice to have a fresh pair of eyes
that notices ways we can improve things like this.

[Zach Stein, 2017-03-27 22:40:10]

The CQ bit was checked by zstein@webrtc.org

[commit-bot: I haz the power, 2017-03-27 22:40:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-27 22:41:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 22:41:49]

Try jobs failed on following builders:
  ios32_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_ios9_dbg/buil...)
  ios_arm64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/18978)
  ios_arm64_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_rel/builds/18774)
  mac_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_rel/builds/24275)

[kwiberg-webrtc, 2017-03-27 22:47:22]

https://codereview.webrtc.org/2757893003/diff/20001/webrtc/base/BUILD.gn
File webrtc/base/BUILD.gn (right):

https://codereview.webrtc.org/2757893003/diff/20001/webrtc/base/BUILD.gn#newc...
webrtc/base/BUILD.gn:853: "ptr_util_unittest.cc",
On 2017/03/23 21:45:54, kwiberg-webrtc wrote:
> Please also add ptr_util.h to a build target. rtc_base_approved is probably
the
> right one.

You seem to have forgotten this...

[Zach Stein, 2017-03-27 22:53:40]

On 2017/03/27 22:47:22, kwiberg-webrtc wrote:
> https://codereview.webrtc.org/2757893003/diff/20001/webrtc/base/BUILD.gn
> File webrtc/base/BUILD.gn (right):
> 
>
https://codereview.webrtc.org/2757893003/diff/20001/webrtc/base/BUILD.gn#newc...
> webrtc/base/BUILD.gn:853: "ptr_util_unittest.cc",
> On 2017/03/23 21:45:54, kwiberg-webrtc wrote:
> > Please also add ptr_util.h to a build target. rtc_base_approved is probably
> the
> > right one.
> 
> You seem to have forgotten this...

Thanks for catching this!

[Zach Stein, 2017-03-27 22:55:30]

The CQ bit was checked by zstein@webrtc.org

[Zach Stein, 2017-03-27 22:55:30]

The patchset sent to the CQ was uploaded after l-g-t-m from deadbeef@webrtc.org,
kwiberg@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2757893003/#ps60001 (title:
"add ptr_util.h to rtc_base_approved build target")

[commit-bot: I haz the power, 2017-03-27 22:55:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-27 23:17:19]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490655330184890,
"parent_rev": "82a707a118212a930944a137a5d15cd006113aba", "commit_rev":
"f42cc9d8d968f9a7483967a6d2de9c8e25c64474"}

[commit-bot: I haz the power, 2017-03-27 23:17:22]

Description was changed from

==========
Add MakeUnique from chromium and change StunMessage::AddAttribute to take a
unique_ptr.

BUG=NONE
==========

to

==========
Add MakeUnique from chromium and change StunMessage::AddAttribute to take a
unique_ptr.

BUG=NONE

Review-Url: https://codereview.webrtc.org/2757893003
Cr-Commit-Position: refs/heads/master@{#17403}
Committed:
https://chromium.googlesource.com/external/webrtc/+/f42cc9d8d968f9a7483967a6d...
==========

[commit-bot: I haz the power, 2017-03-27 23:17:23]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/f42cc9d8d968f9a7483967a6d...