Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 2757843002: Delete unsupported method VideoCodingModule::RegisterDecoderTimingCallback. (Closed)

Created:
3 years, 9 months ago by tommi
Modified:
3 years, 9 months ago
Reviewers:
philipel
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete unsupported method VideoCodingModule::RegisterDecoderTimingCallback. The implementation behind this method has been a noop for a long time. BUG=none Review-Url: https://codereview.webrtc.org/2757843002 Cr-Commit-Position: refs/heads/master@{#17286} Committed: https://chromium.googlesource.com/external/webrtc/+/b1db3702f74bd0283c37a4781d2b4fcf0c2f3c80

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -64 lines) Patch
M webrtc/modules/video_coding/include/video_coding.h View 1 chunk +0 lines, -12 lines 0 comments Download
M webrtc/modules/video_coding/include/video_coding_defines.h View 1 chunk +0 lines, -15 lines 0 comments Download
M webrtc/modules/video_coding/video_coding_impl.h View 2 chunks +0 lines, -3 lines 0 comments Download
M webrtc/modules/video_coding/video_coding_impl.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/modules/video_coding/video_receiver.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M webrtc/video/video_stream_decoder.h View 2 chunks +0 lines, -10 lines 0 comments Download
M webrtc/video/video_stream_decoder.cc View 3 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
tommi
3 years, 9 months ago (2017-03-17 10:49:19 UTC) #2
philipel
lgtm
3 years, 9 months ago (2017-03-17 11:53:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2757843002/1
3 years, 9 months ago (2017-03-17 12:33:28 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 12:35:46 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/b1db3702f74bd0283c37a4781...

Powered by Google App Engine
This is Rietveld 408576698