Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2757213002: Remove voe_base_misc_test.cc. (Closed)

Created:
3 years, 9 months ago by the sun
Modified:
3 years, 9 months ago
Reviewers:
ossu, henrika_webrtc
CC:
webrtc-reviews_webrtc.org, AleBzk, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove voe_base_misc_test.cc. Only one test case in it, testing an API which is deprecated. BUG=webrtc:4690 Review-Url: https://codereview.webrtc.org/2757213002 Cr-Commit-Position: refs/heads/master@{#17372} Committed: https://chromium.googlesource.com/external/webrtc/+/8ed482e6d783c15ae77d0e63caa3f6a15f2bb149

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -26 lines) Patch
M webrtc/voice_engine/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D webrtc/voice_engine/test/auto_test/standard/voe_base_misc_test.cc View 1 chunk +0 lines, -25 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
the sun
3 years, 9 months ago (2017-03-20 09:36:37 UTC) #2
the sun
On 2017/03/20 09:36:37, the sun wrote: ping
3 years, 9 months ago (2017-03-24 10:00:40 UTC) #3
henrika_webrtc
lgtm
3 years, 9 months ago (2017-03-24 10:04:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2757213002/1
3 years, 9 months ago (2017-03-24 10:05:32 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 10:31:05 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/8ed482e6d783c15ae77d0e63c...

Powered by Google App Engine
This is Rietveld 408576698