webrtc/modules/remote_bitrate_estimator/test/estimators/remb.h - Issue 2756483002: Use RTC_UNUSED instead of conditional compilation in BWE simulator tool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/remote_bitrate_estimator/test/estimators/remb.h

Issue 2756483002: Use RTC_UNUSED instead of conditional compilation in BWE simulator tool. (Closed)

Patch Set: Attempt static_cast<void>(x) Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/remote_bitrate_estimator/test/estimators/remb.h

diff --git a/webrtc/modules/remote_bitrate_estimator/test/estimators/remb.h b/webrtc/modules/remote_bitrate_estimator/test/estimators/remb.h

index 855dc6ff0e9a2f15d729b0eb0d53f9d818d55c47..73e4a30db351f3febc4f5e924a873a9aee46aa7c 100644

--- a/webrtc/modules/remote_bitrate_estimator/test/estimators/remb.h

+++ b/webrtc/modules/remote_bitrate_estimator/test/estimators/remb.h

@@ -70,9 +70,7 @@ class RembReceiver : public BweReceiver, public RemoteBitrateObserver {

bool LatestEstimate(uint32_t* estimate_bps);

std::string estimate_log_prefix_;

-#if BWE_TEST_LOGGING_COMPILE_TIME_ENABLE

bool plot_estimate_ = false;

-#endif

SimulatedClock clock_;

std::unique_ptr<ReceiveStatistics> recv_stats_;

int64_t latest_estimate_bps_;