Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Unified Diff: webrtc/modules/remote_bitrate_estimator/test/estimators/remb.cc

Issue 2756483002: Use RTC_UNUSED instead of conditional compilation in BWE simulator tool. (Closed)
Patch Set: Attempt static_cast<void>(x) Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/remote_bitrate_estimator/test/estimators/remb.cc
diff --git a/webrtc/modules/remote_bitrate_estimator/test/estimators/remb.cc b/webrtc/modules/remote_bitrate_estimator/test/estimators/remb.cc
index 39b5c14b05c94a2cf38352c58563b4be1102bf72..9c3e342c8afb711eb5271a4e99fd0c3c30d52ffc 100644
--- a/webrtc/modules/remote_bitrate_estimator/test/estimators/remb.cc
+++ b/webrtc/modules/remote_bitrate_estimator/test/estimators/remb.cc
@@ -17,6 +17,7 @@
#include "webrtc/modules/remote_bitrate_estimator/test/bwe_test_logging.h"
#include "webrtc/modules/rtp_rtcp/include/receive_statistics.h"
#include "webrtc/test/gtest.h"
+#include "webrtc/typedefs.h"
namespace webrtc {
namespace testing {
@@ -65,9 +66,7 @@ int RembBweSender::GetFeedbackIntervalMs() const {
RembReceiver::RembReceiver(int flow_id, bool plot)
: BweReceiver(flow_id),
estimate_log_prefix_(),
-#if BWE_TEST_LOGGING_COMPILE_TIME_ENABLE
plot_estimate_(plot),
-#endif
clock_(0),
recv_stats_(ReceiveStatistics::Create(&clock_)),
latest_estimate_bps_(-1),
@@ -121,13 +120,12 @@ FeedbackPacket* RembReceiver::GetFeedback(int64_t now_ms) {
estimated_bps, latest_report_block_);
last_feedback_ms_ = now_ms;
-#if BWE_TEST_LOGGING_COMPILE_TIME_ENABLE
double estimated_kbps = static_cast<double>(estimated_bps) / 1000.0;
+ RTC_UNUSED(estimated_kbps);
if (plot_estimate_) {
BWE_TEST_LOGGING_PLOT(0, estimate_log_prefix_,
clock_.TimeInMilliseconds(), estimated_kbps);
}
-#endif
}
return feedback;
}

Powered by Google App Engine
This is Rietveld 408576698