Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: webrtc/modules/remote_bitrate_estimator/send_time_history_unittest.cc

Issue 2755553003: Ignore packets sent on old network route when receiving feedback. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/remote_bitrate_estimator/send_time_history_unittest.cc
diff --git a/webrtc/modules/remote_bitrate_estimator/send_time_history_unittest.cc b/webrtc/modules/remote_bitrate_estimator/send_time_history_unittest.cc
index 93c7b8f06ade4cbe12f631bbac2a0d70bca198ad..21965a4a4bf6a80b53d55e14819a4017df4ec5b7 100644
--- a/webrtc/modules/remote_bitrate_estimator/send_time_history_unittest.cc
+++ b/webrtc/modules/remote_bitrate_estimator/send_time_history_unittest.cc
@@ -36,7 +36,9 @@ class SendTimeHistoryTest : public ::testing::Test {
size_t length,
int64_t send_time_ms,
const PacedPacketInfo& pacing_info) {
- history_.AddAndRemoveOld(sequence_number, length, pacing_info);
+ PacketFeedback packet(clock_.TimeInMilliseconds(), -1, -1, sequence_number,
+ length, 0, 0, pacing_info);
+ history_.AddAndRemoveOld(packet);
history_.OnSentPacket(sequence_number, send_time_ms);
}
@@ -97,9 +99,10 @@ TEST_F(SendTimeHistoryTest, AddThenRemoveOutOfOrder) {
static_cast<uint16_t>(i), kPacketSize, PacedPacketInfo()));
}
for (size_t i = 0; i < num_items; ++i) {
- history_.AddAndRemoveOld(sent_packets[i].sequence_number,
- sent_packets[i].payload_size,
- PacedPacketInfo(1, 2, 200));
+ PacketFeedback packet = sent_packets[i];
+ packet.arrival_time_ms = -1;
+ packet.send_time_ms = -1;
+ history_.AddAndRemoveOld(packet);
}
for (size_t i = 0; i < num_items; ++i)
history_.OnSentPacket(sent_packets[i].sequence_number,
@@ -212,28 +215,5 @@ TEST_F(SendTimeHistoryTest, InterlievedGetAndRemove) {
EXPECT_TRUE(history_.GetFeedback(&packet3, true));
EXPECT_EQ(packets[2], packet3);
}
-
-TEST_F(SendTimeHistoryTest, Clear) {
- const uint16_t kSeqNo = 1;
- const int64_t kTimestamp = 2;
- const PacedPacketInfo kPacingInfo(0, 5, 1200);
-
- PacketFeedback packets[] = {{0, kTimestamp, kSeqNo, 0, kPacingInfo},
- {0, kTimestamp + 1, kSeqNo + 1, 0, kPacingInfo}};
-
- AddPacketWithSendTime(packets[0].sequence_number, packets[0].payload_size,
- packets[0].send_time_ms, kPacingInfo);
- AddPacketWithSendTime(packets[1].sequence_number, packets[1].payload_size,
- packets[1].send_time_ms, kPacingInfo);
- PacketFeedback info(0, 0, packets[0].sequence_number, 0, kPacingInfo);
- EXPECT_TRUE(history_.GetFeedback(&info, true));
- EXPECT_EQ(packets[0], info);
-
- history_.Clear();
-
- PacketFeedback info2(0, 0, packets[1].sequence_number, 0, kPacingInfo);
- EXPECT_FALSE(history_.GetFeedback(&info2, true));
-}
-
} // namespace test
} // namespace webrtc

Powered by Google App Engine
This is Rietveld 408576698