Roll chromium_revision 981ff3850e..99c1f4221e (456928:457015)

Roll chromium_revision 981ff3850e..99c1f4221e (456928:457015)

MB was updated to accomodate changes in https://codereview.chromium.org/2695963003

Change log: https://chromium.googlesource.com/chromium/src/+log/981ff3850e..99c1f4221e
Full diff: https://chromium.googlesource.com/chromium/src/+/981ff3850e..99c1f4221e

Changed dependencies:
* src/base: https://chromium.googlesource.com/chromium/src/base/+log/be5cf86ede..6d7c22c4f5
* src/build: https://chromium.googlesource.com/chromium/src/build/+log/2744073131..e8b5e58534
* src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/65ada1572f..8d1f4a15e6
* src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/3d76f6cb4c..d6eb1e0a11
* src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/779bb26879..24999c043d
* src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/f2d0d63fdc..2ffeda5cdc
DEPS diff: https://chromium.googlesource.com/chromium/src/+/981ff3850e..99c1f4221e/DEPS

No update to Clang.

TBR=
BUG=None
NOTRY=True

Review-Url: https://codereview.webrtc.org/2755433005
Cr-Commit-Position: refs/heads/master@{#17238}
Committed: https://chromium.googlesource.com/external/webrtc/+/9f8a566316c226e799def9f10eb689f9aeb0a049

[kjellander_webrtc, 2017-03-15 07:58:56]

kjellander@webrtc.org changed reviewers:
+ ehmaldonado@webrtc.org

[kjellander_webrtc, 2017-03-15 07:58:57]

This is a copy of https://codereview.webrtc.org/2753753003/ with additional
changes attempting to fix the MB error caused by changes in Chromium's
https://codereview.chromium.org/2695963003

I get test failures for MB with this CL which I'm unable to see how to fix.
Edward: can you have a look at what's missing?
I also see Chromium's MB copy doesn't have these tests, but I suspect it might
be good keeping them.


 $ tools-webrtc/mb/mb_unittest.py 
.......FF................
======================================================================
FAIL: test_gn_gen_swarming_android (__main__.UnitTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tools-webrtc/mb/mb_unittest.py", line 373, in
test_gn_gen_swarming_android
    mbw=mbw, ret=0)
  File "tools-webrtc/mb/mb_unittest.py", line 230, in check
    self.assertEqual(actual_ret, ret)
AssertionError: 1 != 0

======================================================================
FAIL: test_gn_gen_swarming_android_junit_test (__main__.UnitTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tools-webrtc/mb/mb_unittest.py", line 405, in
test_gn_gen_swarming_android_junit_test
    mbw=mbw, ret=0)
  File "tools-webrtc/mb/mb_unittest.py", line 230, in check
    self.assertEqual(actual_ret, ret)
AssertionError: 1 != 0

----------------------------------------------------------------------
Ran 25 tests in 0.259s

FAILED (failures=2)

[kjellander_webrtc, 2017-03-15 09:22:02]

Description was changed from

==========
Roll chromium_revision 981ff3850e..99c1f4221e (456928:457015)

MB was updated to accomodate changes in
https://codereview.chromium.org/2695963003

Change log:
https://chromium.googlesource.com/chromium/src/+log/981ff3850e..99c1f4221e
Full diff:
https://chromium.googlesource.com/chromium/src/+/981ff3850e..99c1f4221e

Changed dependencies:
* src/base:
https://chromium.googlesource.com/chromium/src/base/+log/be5cf86ede..6d7c22c4f5
* src/build:
https://chromium.googlesource.com/chromium/src/build/+log/2744073131..e8b5e58534
* src/ios:
https://chromium.googlesource.com/chromium/src/ios/+log/65ada1572f..8d1f4a15e6
* src/testing:
https://chromium.googlesource.com/chromium/src/testing/+log/3d76f6cb4c..d6eb1...
* src/third_party:
https://chromium.googlesource.com/chromium/src/third_party/+log/779bb26879..2...
* src/tools:
https://chromium.googlesource.com/chromium/src/tools/+log/f2d0d63fdc..2ffeda5cdc
DEPS diff:
https://chromium.googlesource.com/chromium/src/+/981ff3850e..99c1f4221e/DEPS

No update to Clang.

TBR=
BUG=None
==========

to

==========
Roll chromium_revision 981ff3850e..99c1f4221e (456928:457015)

MB was updated to accomodate changes in
https://codereview.chromium.org/2695963003

Change log:
https://chromium.googlesource.com/chromium/src/+log/981ff3850e..99c1f4221e
Full diff:
https://chromium.googlesource.com/chromium/src/+/981ff3850e..99c1f4221e

Changed dependencies:
* src/base:
https://chromium.googlesource.com/chromium/src/base/+log/be5cf86ede..6d7c22c4f5
* src/build:
https://chromium.googlesource.com/chromium/src/build/+log/2744073131..e8b5e58534
* src/ios:
https://chromium.googlesource.com/chromium/src/ios/+log/65ada1572f..8d1f4a15e6
* src/testing:
https://chromium.googlesource.com/chromium/src/testing/+log/3d76f6cb4c..d6eb1...
* src/third_party:
https://chromium.googlesource.com/chromium/src/third_party/+log/779bb26879..2...
* src/tools:
https://chromium.googlesource.com/chromium/src/tools/+log/f2d0d63fdc..2ffeda5cdc
DEPS diff:
https://chromium.googlesource.com/chromium/src/+/981ff3850e..99c1f4221e/DEPS

No update to Clang.

TBR=
BUG=None
NOTRY=True
==========

[kjellander_webrtc, 2017-03-15 09:22:49]

On 2017/03/15 07:58:57, kjellander_webrtc wrote:
> This is a copy of https://codereview.webrtc.org/2753753003/ with additional
> changes attempting to fix the MB error caused by changes in Chromium's
> https://codereview.chromium.org/2695963003
> 
> I get test failures for MB with this CL which I'm unable to see how to fix.
> Edward: can you have a look at what's missing?
> I also see Chromium's MB copy doesn't have these tests, but I suspect it might
> be good keeping them.
> 
> 
>  $ tools-webrtc/mb/mb_unittest.py 
> .......FF................
> ======================================================================
> FAIL: test_gn_gen_swarming_android (__main__.UnitTest)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "tools-webrtc/mb/mb_unittest.py", line 373, in
> test_gn_gen_swarming_android
>     mbw=mbw, ret=0)
>   File "tools-webrtc/mb/mb_unittest.py", line 230, in check
>     self.assertEqual(actual_ret, ret)
> AssertionError: 1 != 0
> 
> ======================================================================
> FAIL: test_gn_gen_swarming_android_junit_test (__main__.UnitTest)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "tools-webrtc/mb/mb_unittest.py", line 405, in
> test_gn_gen_swarming_android_junit_test
>     mbw=mbw, ret=0)
>   File "tools-webrtc/mb/mb_unittest.py", line 230, in check
>     self.assertEqual(actual_ret, ret)
> AssertionError: 1 != 0
> 
> ----------------------------------------------------------------------
> Ran 25 tests in 0.259s
> 
> FAILED (failures=2)

Nevermind, it was just a simple Python error. Too bad the test failure didn't
say more.
Landing now as all trybots that failed in
https://codereview.webrtc.org/2753753003/ are passing.

[kjellander_webrtc, 2017-03-15 09:28:52]

The CQ bit was checked by kjellander@webrtc.org

[commit-bot: I haz the power, 2017-03-15 09:28:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-15 09:31:11]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489570132610680,
"parent_rev": "23c595adbae1cd324d55cedb31cae5d748454e66", "commit_rev":
"9f8a566316c226e799def9f10eb689f9aeb0a049"}

[commit-bot: I haz the power, 2017-03-15 09:31:14]

Description was changed from

==========
Roll chromium_revision 981ff3850e..99c1f4221e (456928:457015)

MB was updated to accomodate changes in
https://codereview.chromium.org/2695963003

Change log:
https://chromium.googlesource.com/chromium/src/+log/981ff3850e..99c1f4221e
Full diff:
https://chromium.googlesource.com/chromium/src/+/981ff3850e..99c1f4221e

Changed dependencies:
* src/base:
https://chromium.googlesource.com/chromium/src/base/+log/be5cf86ede..6d7c22c4f5
* src/build:
https://chromium.googlesource.com/chromium/src/build/+log/2744073131..e8b5e58534
* src/ios:
https://chromium.googlesource.com/chromium/src/ios/+log/65ada1572f..8d1f4a15e6
* src/testing:
https://chromium.googlesource.com/chromium/src/testing/+log/3d76f6cb4c..d6eb1...
* src/third_party:
https://chromium.googlesource.com/chromium/src/third_party/+log/779bb26879..2...
* src/tools:
https://chromium.googlesource.com/chromium/src/tools/+log/f2d0d63fdc..2ffeda5cdc
DEPS diff:
https://chromium.googlesource.com/chromium/src/+/981ff3850e..99c1f4221e/DEPS

No update to Clang.

TBR=
BUG=None
NOTRY=True
==========

to

==========
Roll chromium_revision 981ff3850e..99c1f4221e (456928:457015)

MB was updated to accomodate changes in
https://codereview.chromium.org/2695963003

Change log:
https://chromium.googlesource.com/chromium/src/+log/981ff3850e..99c1f4221e
Full diff:
https://chromium.googlesource.com/chromium/src/+/981ff3850e..99c1f4221e

Changed dependencies:
* src/base:
https://chromium.googlesource.com/chromium/src/base/+log/be5cf86ede..6d7c22c4f5
* src/build:
https://chromium.googlesource.com/chromium/src/build/+log/2744073131..e8b5e58534
* src/ios:
https://chromium.googlesource.com/chromium/src/ios/+log/65ada1572f..8d1f4a15e6
* src/testing:
https://chromium.googlesource.com/chromium/src/testing/+log/3d76f6cb4c..d6eb1...
* src/third_party:
https://chromium.googlesource.com/chromium/src/third_party/+log/779bb26879..2...
* src/tools:
https://chromium.googlesource.com/chromium/src/tools/+log/f2d0d63fdc..2ffeda5cdc
DEPS diff:
https://chromium.googlesource.com/chromium/src/+/981ff3850e..99c1f4221e/DEPS

No update to Clang.

TBR=
BUG=None
NOTRY=True

Review-Url: https://codereview.webrtc.org/2755433005
Cr-Commit-Position: refs/heads/master@{#17238}
Committed:
https://chromium.googlesource.com/external/webrtc/+/9f8a566316c226e799def9f10...
==========

[commit-bot: I haz the power, 2017-03-15 09:31:15]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/9f8a566316c226e799def9f10...