Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Issue 2754893002: GN: Make //webrtc/test:fileutils visible only to //webrtc/test. (Closed)

Created:
3 years, 9 months ago by ehmaldonado_webrtc
Modified:
3 years, 9 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, zhuangzesen_agora.io, stefan-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

GN: Make //webrtc/test:fileutils visible only to //webrtc/test. BUG=webrtc:6727 NOTRY=True Review-Url: https://codereview.webrtc.org/2754893002 Cr-Commit-Position: refs/heads/master@{#17283} Committed: https://chromium.googlesource.com/external/webrtc/+/90474ccd1255c6b44e7a7938fa4298795306c9b1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M webrtc/modules/audio_coding/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
ehmaldonado_webrtc
PTAL :)
3 years, 9 months ago (2017-03-16 17:38:36 UTC) #2
kjellander_webrtc
lgtm I suggest a run with compile-only bots and then NOTRY=True
3 years, 9 months ago (2017-03-16 18:36:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2754893002/1
3 years, 9 months ago (2017-03-17 10:45:10 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 10:47:29 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/90474ccd1255c6b44e7a7938f...

Powered by Google App Engine
This is Rietveld 408576698