Fix DesktopCapturer constructors to handle failures properly.

Fix DesktopCapturer constructors to handle failures properly.

CreateRawScreenCapturer() and CreateRawWindowCapturer() in
DesktopCapturer are allowed to return nullptr when capturer cannot be
initialized for some reason. CreateWindowCapturer() and
CreateScreenCapturer() in DesktopCapturer were not handling this case
correctly, which may lead to crash.

BUG=chromium:702745
Review-Url: https://codereview.webrtc.org/2754403002
Cr-Commit-Position: refs/heads/master@{#17298}
Committed: https://chromium.googlesource.com/external/webrtc/+/3eba2d82737932660aae18fe4ad169414a3c3313

[Sergey Ulanov, 2017-03-17 19:43:28]

sergeyu@chromium.org changed reviewers:
+ zijiehe@chromium.org

[Hzj_jie, 2017-03-17 19:55:02]

On 2017/03/17 19:43:28, Sergey Ulanov wrote:

lgtm

[Sergey Ulanov, 2017-03-17 19:55:38]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2017-03-17 19:55:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[Sergey Ulanov, 2017-03-17 19:55:44]

The CQ bit was unchecked by sergeyu@chromium.org

[Sergey Ulanov, 2017-03-17 19:55:53]

Description was changed from

==========
Fix DesktopCapturer constructors to handle failures properly.

CreateRawScreenCapturer() and CreateRawWindowCapturer() in
DesktopCapturer are allowed to return nullptr when capturer cannot be
initialized for some reason. CreateWindowCapturer() and
CreateScreenCapturer() in DesktopCapturer were not handling this case
correctly, which may lead to crash.

BUG=702745
==========

to

==========
Fix DesktopCapturer constructors to handle failures properly.

CreateRawScreenCapturer() and CreateRawWindowCapturer() in
DesktopCapturer are allowed to return nullptr when capturer cannot be
initialized for some reason. CreateWindowCapturer() and
CreateScreenCapturer() in DesktopCapturer were not handling this case
correctly, which may lead to crash.

BUG=chromium:702745
==========

[Sergey Ulanov, 2017-03-17 19:55:56]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2017-03-17 19:56:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-17 20:09:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 20:09:48]

Try jobs failed on following builders:
  ios32_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_ios9_dbg/buil...)

[Sergey Ulanov, 2017-03-17 22:18:14]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2017-03-17 22:18:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-17 22:33:28]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489789094351270, "parent_rev":
"5f54419ae516adcc935939079b89c5c9ede6adf0", "commit_rev":
"3eba2d82737932660aae18fe4ad169414a3c3313"}

[commit-bot: I haz the power, 2017-03-17 22:33:31]

Description was changed from

==========
Fix DesktopCapturer constructors to handle failures properly.

CreateRawScreenCapturer() and CreateRawWindowCapturer() in
DesktopCapturer are allowed to return nullptr when capturer cannot be
initialized for some reason. CreateWindowCapturer() and
CreateScreenCapturer() in DesktopCapturer were not handling this case
correctly, which may lead to crash.

BUG=chromium:702745
==========

to

==========
Fix DesktopCapturer constructors to handle failures properly.

CreateRawScreenCapturer() and CreateRawWindowCapturer() in
DesktopCapturer are allowed to return nullptr when capturer cannot be
initialized for some reason. CreateWindowCapturer() and
CreateScreenCapturer() in DesktopCapturer were not handling this case
correctly, which may lead to crash.

BUG=chromium:702745

Review-Url: https://codereview.webrtc.org/2754403002
Cr-Commit-Position: refs/heads/master@{#17298}
Committed:
https://chromium.googlesource.com/external/webrtc/+/3eba2d82737932660aae18fe4...
==========

[commit-bot: I haz the power, 2017-03-17 22:33:32]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/3eba2d82737932660aae18fe4...