Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 2753423002: Add a missing DCHECK to PlatformThread::SetPriority. (Closed)

Created:
3 years, 9 months ago by tommi
Modified:
3 years, 9 months ago
Reviewers:
kthelgason
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add a missing DCHECK to PlatformThread::SetPriority. This DCHECK is for the 'new and improved' way of setting thread priority. What could happen is that code that's migrating over to the new method might still have a lingering SetPriority call, that could incorrectly bind the 'spawned_thread_checker_' to the construction thread. BUG=none Review-Url: https://codereview.webrtc.org/2753423002 Cr-Commit-Position: refs/heads/master@{#17305} Committed: https://chromium.googlesource.com/external/webrtc/+/7c3da271419ceeef6601c99dcb5cb5400b7157c4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M webrtc/base/platform_thread.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
tommi
3 years, 9 months ago (2017-03-18 23:54:04 UTC) #2
kthelgason
lgtm
3 years, 9 months ago (2017-03-20 08:27:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2753423002/1
3 years, 9 months ago (2017-03-20 10:25:29 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-20 10:47:21 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/7c3da271419ceeef6601c99dc...

Powered by Google App Engine
This is Rietveld 408576698