Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(875)

Issue 2753343002: Add CryptoParams to webrtc::MediaSession. (Closed)

Created:
3 years, 9 months ago by Zach Stein
Modified:
3 years, 9 months ago
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add CryptoParams to webrtc::MediaSession. SrtpTransportInterface methods take cricket::CryptoParams, so this should be enough for now. BUG=webrtc:7311 Review-Url: https://codereview.webrtc.org/2753343002 Cr-Commit-Position: refs/heads/master@{#17299} Committed: https://chromium.googlesource.com/external/webrtc/+/7aeabd081f148e489d1e9d360c3fe7587a92b606

Patch Set 1 #

Patch Set 2 : add an sdes_params unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M webrtc/api/ortc/mediadescription.h View 2 chunks +12 lines, -0 lines 0 comments Download
M webrtc/api/ortc/mediadescription_unittest.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Taylor Brandstetter
lgtm. I guess this ended up being simpler than I thought; I wasn't sure at ...
3 years, 9 months ago (2017-03-17 23:50:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2753343002/20001
3 years, 9 months ago (2017-03-17 23:58:48 UTC) #4
commit-bot: I haz the power
3 years, 9 months ago (2017-03-18 02:10:45 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/7aeabd081f148e489d1e9d360...

Powered by Google App Engine
This is Rietveld 408576698