Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2751653006:
TransportFeedbackPacketLossTrackerTest cosmetic modification (Closed)
|
Created:
3 years, 9 months ago by elad.alon Modified:
3 years, 9 months ago CC:
webrtc-reviews_webrtc.org, AleBzk, henrika_webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionTransportFeedbackPacketLossTrackerTest cosmetic modification
BUG=webrtc:7058
Review-Url: https://codereview.webrtc.org/2751653006
Cr-Commit-Position: refs/heads/master@{#17320}
Committed: https://chromium.googlesource.com/external/webrtc/+/6a64bd96bf8cdf795487cd4433415b7f85061927
Patch Set 1 #
Total comments: 4
Patch Set 2 : . #Patch Set 3 : Rebased #
Total comments: 2
Patch Set 4 : Add "Ms" #Messages
Total messages: 22 (10 generated)
Description was changed from ========== UT constant BUG=None ========== to ========== TransportFeedbackPacketLossTrackerTest cosmetic modification BUG=None ==========
elad.alon@webrtc.org changed reviewers: + minyue@webrtc.org
Ook? :-)
https://codereview.webrtc.org/2751653006/diff/1/webrtc/voice_engine/transport... File webrtc/voice_engine/transport_feedback_packet_loss_tracker_unittest.cc (right): https://codereview.webrtc.org/2751653006/diff/1/webrtc/voice_engine/transport... webrtc/voice_engine/transport_feedback_packet_loss_tracker_unittest.cc:25: constexpr int64_t kDefaultSendIntervalMs = 10 https://codereview.webrtc.org/2751653006/diff/1/webrtc/voice_engine/transport... webrtc/voice_engine/transport_feedback_packet_loss_tracker_unittest.cc:27: you may also constexpr int kDefaultMaxWindowSizeMs = 500 * kDefaultSendInterval;
https://codereview.webrtc.org/2751653006/diff/1/webrtc/voice_engine/transport... File webrtc/voice_engine/transport_feedback_packet_loss_tracker_unittest.cc (right): https://codereview.webrtc.org/2751653006/diff/1/webrtc/voice_engine/transport... webrtc/voice_engine/transport_feedback_packet_loss_tracker_unittest.cc:25: On 2017/03/15 14:33:55, minyue-webrtc(OOO_until_Mar19) wrote: > constexpr int64_t kDefaultSendIntervalMs = 10 Right you are! https://codereview.webrtc.org/2751653006/diff/1/webrtc/voice_engine/transport... webrtc/voice_engine/transport_feedback_packet_loss_tracker_unittest.cc:27: On 2017/03/15 14:33:55, minyue-webrtc(OOO_until_Mar19) wrote: > you may also > > constexpr int kDefaultMaxWindowSizeMs = 500 * kDefaultSendInterval; Done.
Description was changed from ========== TransportFeedbackPacketLossTrackerTest cosmetic modification BUG=None ========== to ========== TransportFeedbackPacketLossTrackerTest cosmetic modification BUG=webrtc:7058 ==========
On 2017/03/16 17:17:20, elad.alon wrote: > https://codereview.webrtc.org/2751653006/diff/1/webrtc/voice_engine/transport... > File webrtc/voice_engine/transport_feedback_packet_loss_tracker_unittest.cc > (right): > > https://codereview.webrtc.org/2751653006/diff/1/webrtc/voice_engine/transport... > webrtc/voice_engine/transport_feedback_packet_loss_tracker_unittest.cc:25: > On 2017/03/15 14:33:55, minyue-webrtc(OOO_until_Mar19) wrote: > > constexpr int64_t kDefaultSendIntervalMs = 10 > > Right you are! > > https://codereview.webrtc.org/2751653006/diff/1/webrtc/voice_engine/transport... > webrtc/voice_engine/transport_feedback_packet_loss_tracker_unittest.cc:27: > On 2017/03/15 14:33:55, minyue-webrtc(OOO_until_Mar19) wrote: > > you may also > > > > constexpr int kDefaultMaxWindowSizeMs = 500 * kDefaultSendInterval; > > Done. Anything else?
Ping :-)
lgtm only a nit https://codereview.webrtc.org/2751653006/diff/40001/webrtc/voice_engine/trans... File webrtc/voice_engine/transport_feedback_packet_loss_tracker_unittest.cc (right): https://codereview.webrtc.org/2751653006/diff/40001/webrtc/voice_engine/trans... webrtc/voice_engine/transport_feedback_packet_loss_tracker_unittest.cc:26: constexpr int64_t kDefaultSendInterval = 10; you missed adding "Ms"
elad.alon@webrtc.org changed reviewers: + solenberg@webrtc.org
Adding Fredrick - need an owner to lgtm-ize. https://codereview.webrtc.org/2751653006/diff/40001/webrtc/voice_engine/trans... File webrtc/voice_engine/transport_feedback_packet_loss_tracker_unittest.cc (right): https://codereview.webrtc.org/2751653006/diff/40001/webrtc/voice_engine/trans... webrtc/voice_engine/transport_feedback_packet_loss_tracker_unittest.cc:26: constexpr int64_t kDefaultSendInterval = 10; On 2017/03/20 21:05:55, minyue-webrtc wrote: > you missed adding "Ms" Done.
The CQ bit was checked by elad.alon@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from minyue@webrtc.org Link to the patchset: https://codereview.webrtc.org/2751653006/#ps60001 (title: "Add "Ms"")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/15171)
lgtm
The CQ bit was checked by elad.alon@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490100948137440,
"parent_rev": "54ca919c328d380a68fdb6f2dba3cc30da4aeefc", "commit_rev":
"6a64bd96bf8cdf795487cd4433415b7f85061927"}
Message was sent while issue was closed.
Description was changed from ========== TransportFeedbackPacketLossTrackerTest cosmetic modification BUG=webrtc:7058 ========== to ========== TransportFeedbackPacketLossTrackerTest cosmetic modification BUG=webrtc:7058 Review-Url: https://codereview.webrtc.org/2751653006 Cr-Commit-Position: refs/heads/master@{#17320} Committed: https://chromium.googlesource.com/external/webrtc/+/6a64bd96bf8cdf795487cd443... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/external/webrtc/+/6a64bd96bf8cdf795487cd443... |
