bluetooth: Stop support of reconnecting devices not supporting pairing

bluetooth: Stop support of reconnecting devices not supporting pairing

This stops the support of reconnection to the following Bluetooth device due to
their lack of pairing mechanism.
- Verbatim Bluetooth Mouse, model 96674
- Microsoft Bluetooth Notebook Mouse 5000, model X807028-001
- Sony PlayStation Dualshock3

BUG=701992
TBR=ortuno@chromium.org

Review-Url: https://codereview.chromium.org/2751223002
Cr-Commit-Position: refs/heads/master@{#457325}
Committed: https://chromium.googlesource.com/chromium/src/+/206866029e5e2fddc1cff642fbfc5318007a6574

[Miao, 2017-03-15 22:35:43]

Description was changed from

==========
bluetooth: Stop support of reconnecting devices not supporting pairing

This stops the support of reconnection to the following Bluetooth device due to
their lack of pairing mechanism.
- Verbatim Bluetooth Mouse, model 96674
- Microsoft Bluetooth Notebook Mouse 5000, model X807028-001
- Sony PlayStation Dualshock3

BUG=701992
==========

to

==========
bluetooth: Stop support of reconnecting devices not supporting pairing

This stops the support of reconnection to the following Bluetooth device due to
their lack of pairing mechanism.
- Verbatim Bluetooth Mouse, model 96674
- Microsoft Bluetooth Notebook Mouse 5000, model X807028-001
- Sony PlayStation Dualshock3

BUG=701992
==========

[Miao, 2017-03-15 22:35:43]

mcchou@chromium.org changed reviewers:
+ dmitrygr@google.com, steel@chromium.org

[mcchou, 2017-03-15 22:36:37]

The CQ bit was checked by mcchou@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 22:37:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dmitrygr, 2017-03-15 22:39:50]

https://codereview.chromium.org/2751223002/diff/1/device/bluetooth/bluez/blue...
File device/bluetooth/bluez/bluetooth_device_bluez.cc (right):

https://codereview.chromium.org/2751223002/diff/1/device/bluetooth/bluez/blue...
device/bluetooth/bluez/bluetooth_device_bluez.cc:338: // support pairing. Once a
device is paired successfully, the Trusted
You mean "Paired" property?

[commit-bot: I haz the power, 2017-03-15 22:43:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 22:43:41]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[rkc, 2017-03-15 22:49:01]

rkc@chromium.org changed reviewers:
+ rkc@chromium.org

[rkc, 2017-03-15 22:49:02]

lgtm

https://codereview.chromium.org/2751223002/diff/1/device/bluetooth/bluez/blue...
File device/bluetooth/bluez/bluetooth_device_bluez.cc (right):

https://codereview.chromium.org/2751223002/diff/1/device/bluetooth/bluez/blue...
device/bluetooth/bluez/bluetooth_device_bluez.cc:336: // The Paired property
reflects the successful pairing for BR/EDR/BLE. The
nit: BR/EDR/LE

[mcchou, 2017-03-15 22:52:55]

The CQ bit was checked by mcchou@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 22:53:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Miao, 2017-03-15 22:57:19]

On 2017/03/15 22:39:50, dmitrygr wrote:
>
https://codereview.chromium.org/2751223002/diff/1/device/bluetooth/bluez/blue...
> File device/bluetooth/bluez/bluetooth_device_bluez.cc (right):
> 
>
https://codereview.chromium.org/2751223002/diff/1/device/bluetooth/bluez/blue...
> device/bluetooth/bluez/bluetooth_device_bluez.cc:338: // support pairing. Once
a
> device is paired successfully, the Trusted
> You mean "Paired" property?

Addressed in patch set 2.

[Miao, 2017-03-15 22:57:31]

On 2017/03/15 22:49:02, rkc wrote:
> lgtm
> 
>
https://codereview.chromium.org/2751223002/diff/1/device/bluetooth/bluez/blue...
> File device/bluetooth/bluez/bluetooth_device_bluez.cc (right):
> 
>
https://codereview.chromium.org/2751223002/diff/1/device/bluetooth/bluez/blue...
> device/bluetooth/bluez/bluetooth_device_bluez.cc:336: // The Paired property
> reflects the successful pairing for BR/EDR/BLE. The
> nit: BR/EDR/LE

Addressed in patch set 2.

[commit-bot: I haz the power, 2017-03-15 23:33:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 23:33:35]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mcchou, 2017-03-15 23:34:17]

The CQ bit was checked by mcchou@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 23:35:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dmitrygr, 2017-03-15 23:45:59]

lgtm

[commit-bot: I haz the power, 2017-03-16 01:14:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 01:14:32]

Dry run: This issue passed the CQ dry run.

[Miao, 2017-03-16 01:16:29]

The CQ bit was checked by mcchou@chromium.org

[Miao, 2017-03-16 01:16:29]

The patchset sent to the CQ was uploaded after l-g-t-m from rkc@chromium.org
Link to the patchset: https://codereview.chromium.org/2751223002/#ps40001
(title: "fix an unittest failure")

[commit-bot: I haz the power, 2017-03-16 01:17:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 01:24:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 01:24:40]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Miao, 2017-03-16 01:29:26]

mcchou@chromium.org changed reviewers:
+ ortuno@chromium.org

[Miao, 2017-03-16 01:30:27]

mcchou@chromium.org changed reviewers:
+ scheib@chromium.org

[Miao, 2017-03-16 01:54:40]

Description was changed from

==========
bluetooth: Stop support of reconnecting devices not supporting pairing

This stops the support of reconnection to the following Bluetooth device due to
their lack of pairing mechanism.
- Verbatim Bluetooth Mouse, model 96674
- Microsoft Bluetooth Notebook Mouse 5000, model X807028-001
- Sony PlayStation Dualshock3

BUG=701992
==========

to

==========
bluetooth: Stop support of reconnecting devices not supporting pairing

This stops the support of reconnection to the following Bluetooth device due to
their lack of pairing mechanism.
- Verbatim Bluetooth Mouse, model 96674
- Microsoft Bluetooth Notebook Mouse 5000, model X807028-001
- Sony PlayStation Dualshock3

BUG=701992
TBR=ortuno@chromium.org
==========

[Miao, 2017-03-16 01:55:43]

The CQ bit was checked by mcchou@chromium.org

[commit-bot: I haz the power, 2017-03-16 01:56:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 02:00:46]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489629343468680,
"parent_rev": "3249af70be7a33e4c48f58bf9d415dae8575a9e5", "commit_rev":
"855ccf57370fc3b13f76f4e30f926e960f6cc927"}

[commit-bot: I haz the power, 2017-03-16 02:09:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 02:09:16]

Prior attempt to commit was detected, but we were not able to check whether the
issue was successfully committed. Please check Git history manually and re-check
CQ or close this issue as needed.

[Miao, 2017-03-16 02:31:19]

The CQ bit was checked by mcchou@chromium.org

[commit-bot: I haz the power, 2017-03-16 02:31:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 02:35:51]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489631479934610,
"parent_rev": "75609e13c825b3783c782ad0559d5c603d04d82d", "commit_rev":
"206866029e5e2fddc1cff642fbfc5318007a6574"}

[commit-bot: I haz the power, 2017-03-16 02:36:35]

Description was changed from

==========
bluetooth: Stop support of reconnecting devices not supporting pairing

This stops the support of reconnection to the following Bluetooth device due to
their lack of pairing mechanism.
- Verbatim Bluetooth Mouse, model 96674
- Microsoft Bluetooth Notebook Mouse 5000, model X807028-001
- Sony PlayStation Dualshock3

BUG=701992
TBR=ortuno@chromium.org
==========

to

==========
bluetooth: Stop support of reconnecting devices not supporting pairing

This stops the support of reconnection to the following Bluetooth device due to
their lack of pairing mechanism.
- Verbatim Bluetooth Mouse, model 96674
- Microsoft Bluetooth Notebook Mouse 5000, model X807028-001
- Sony PlayStation Dualshock3

BUG=701992
TBR=ortuno@chromium.org

Review-Url: https://codereview.chromium.org/2751223002
Cr-Commit-Position: refs/heads/master@{#457325}
Committed:
https://chromium.googlesource.com/chromium/src/+/206866029e5e2fddc1cff642fbfc...
==========

[commit-bot: I haz the power, 2017-03-16 02:36:36]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/206866029e5e2fddc1cff642fbfc...

[scheib, 2017-03-16 03:56:59]

lgtm

[ortuno, 2017-03-28 02:09:26]

Sorry, I was OOO.

https://codereview.chromium.org/2751223002/diff/40001/device/bluetooth/bluez/...
File device/bluetooth/bluez/bluetooth_device_bluez.cc (right):

https://codereview.chromium.org/2751223002/diff/40001/device/bluetooth/bluez/...
device/bluetooth/bluez/bluetooth_device_bluez.cc:257: // TODO(crbug.com/649651):
Use IsPaired once it returns true only for paired
You can also remove this TODO.