Pass label and plot style to the TimeSeries' constructor.

Pass label and plot style to the TimeSeries' constructor.

BUG=webrtc:7323
Review-Url: https://codereview.webrtc.org/2750583002
Cr-Commit-Position: refs/heads/master@{#17237}
Committed: https://chromium.googlesource.com/external/webrtc/+/23c595adbae1cd324d55cedb31cae5d748454e66

[terelius, 2017-03-13 14:37:37]

The CQ bit was checked by terelius@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-13 14:37:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[terelius, 2017-03-13 14:40:37]

terelius@webrtc.org changed reviewers:
+ michaelt@webrtc.org

[commit-bot: I haz the power, 2017-03-13 15:10:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-13 15:10:35]

Dry run: This issue passed the CQ dry run.

[michaelt, 2017-03-13 15:36:43]

Nice idea.

https://codereview.webrtc.org/2750583002/diff/1/webrtc/tools/event_log_visual...
File webrtc/tools/event_log_visualizer/plot_base.h (right):

https://codereview.webrtc.org/2750583002/diff/1/webrtc/tools/event_log_visual...
webrtc/tools/event_log_visualizer/plot_base.h:105: TimeSeries*
AddTimeSeries(const char* label, PlotStyle style) {
Shouldn't we code this in the cc file ?

[terelius, 2017-03-14 17:12:25]

The CQ bit was checked by terelius@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 17:12:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[terelius, 2017-03-14 17:13:59]

https://codereview.webrtc.org/2750583002/diff/1/webrtc/tools/event_log_visual...
File webrtc/tools/event_log_visualizer/plot_base.h (right):

https://codereview.webrtc.org/2750583002/diff/1/webrtc/tools/event_log_visual...
webrtc/tools/event_log_visualizer/plot_base.h:105: TimeSeries*
AddTimeSeries(const char* label, PlotStyle style) {
On 2017/03/13 15:36:42, michaelt wrote:
> Shouldn't we code this in the cc file ?

Yes. Done.

[commit-bot: I haz the power, 2017-03-14 17:36:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 17:36:00]

Dry run: This issue passed the CQ dry run.

[michaelt, 2017-03-15 08:10:31]

lgtm

[terelius, 2017-03-15 08:54:40]

The CQ bit was checked by terelius@webrtc.org

[commit-bot: I haz the power, 2017-03-15 08:54:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-15 08:59:12]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489568080693790,
"parent_rev": "5d389dbde0943ca934d0ebb01e3a11be950df479", "commit_rev":
"23c595adbae1cd324d55cedb31cae5d748454e66"}

[commit-bot: I haz the power, 2017-03-15 08:59:15]

Description was changed from

==========
Pass label and plot style to the TimeSeries' constructor.

BUG=webrtc:7323
==========

to

==========
Pass label and plot style to the TimeSeries' constructor.

BUG=webrtc:7323

Review-Url: https://codereview.webrtc.org/2750583002
Cr-Commit-Position: refs/heads/master@{#17237}
Committed:
https://chromium.googlesource.com/external/webrtc/+/23c595adbae1cd324d55cedb3...
==========

[commit-bot: I haz the power, 2017-03-15 08:59:16]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/23c595adbae1cd324d55cedb3...