Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 2749563002: Change FrameBuffer::Stop to not require a critical section. (Closed)

Created:
3 years, 9 months ago by tommi
Modified:
3 years, 9 months ago
Reviewers:
philipel
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Change FrameBuffer::Stop to not require a critical section. BUG=webrtc:7331 Review-Url: https://codereview.webrtc.org/2749563002 Cr-Commit-Position: refs/heads/master@{#17228} Committed: https://chromium.googlesource.com/external/webrtc/+/0a735643388622494cd59720a40b51899985be99

Patch Set 1 #

Patch Set 2 : Remove extra check #

Patch Set 3 : Restore the Reset() call #

Patch Set 4 : Add comment and link to bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -21 lines) Patch
M webrtc/modules/video_coding/frame_buffer2.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/frame_buffer2.cc View 1 2 3 8 chunks +33 lines, -19 lines 0 comments Download

Messages

Total messages: 23 (14 generated)
tommi
Remove extra check
3 years, 9 months ago (2017-03-13 14:47:34 UTC) #1
tommi
ptal
3 years, 9 months ago (2017-03-13 14:48:08 UTC) #3
tommi
Restore the Reset() call
3 years, 9 months ago (2017-03-13 14:56:14 UTC) #6
philipel
This might solve the crash, but I would like to know what is causing the ...
3 years, 9 months ago (2017-03-14 09:51:48 UTC) #11
tommi
Add comment and link to bug
3 years, 9 months ago (2017-03-14 12:28:39 UTC) #12
tommi
On 2017/03/14 09:51:48, philipel wrote: > This might solve the crash, but I would like ...
3 years, 9 months ago (2017-03-14 12:29:17 UTC) #13
philipel
lgtm
3 years, 9 months ago (2017-03-14 13:17:51 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2749563002/60001
3 years, 9 months ago (2017-03-14 13:21:43 UTC) #20
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 13:24:01 UTC) #23
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/0a735643388622494cd59720a...

Powered by Google App Engine
This is Rietveld 408576698