Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 2748863003: Try re-enabling two PeerConnectionClientTests: (Closed)

Created:
3 years, 9 months ago by sakal
Modified:
3 years, 9 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Try re-enabling two PeerConnectionClientTests: - org.appspot.apprtc.test.PeerConnectionClientTest#testCaptureFormatChange - org.appspot.apprtc.test.PeerConnectionClientTest#testVideoSourceRestart The tests were previously flaky but significant changes to the test architecture have been made since. Opportunistically try to re-enable them. BUG=webrtc:6478 Review-Url: https://codereview.webrtc.org/2748863003 Cr-Commit-Position: refs/heads/master@{#17245} Committed: https://chromium.googlesource.com/external/webrtc/+/8444405aa4decdc56a5ab09c6eed57a6530cad2d

Patch Set 1 #

Patch Set 2 : Remove the other comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7 lines) Patch
M webrtc/examples/androidtests/src/org/appspot/apprtc/test/PeerConnectionClientTest.java View 1 3 chunks +2 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
sakal
PTAL
3 years, 9 months ago (2017-03-14 15:06:47 UTC) #7
magjed_webrtc
lgtm
3 years, 9 months ago (2017-03-15 12:05:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2748863003/20001
3 years, 9 months ago (2017-03-15 12:08:58 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 12:50:17 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/8444405aa4decdc56a5ab09c6...

Powered by Google App Engine
This is Rietveld 408576698