webrtc/pc/peerconnection.h - Issue 2748253003: Pass ownership of candidate to PeerConnection::OnIceCandidate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/pc/peerconnection.h

Issue 2748253003: Pass ownership of candidate to PeerConnection::OnIceCandidate (Closed)

Patch Set: Pass ownership through std::unique_ptr Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/pc/peerconnection.h

diff --git a/webrtc/pc/peerconnection.h b/webrtc/pc/peerconnection.h

index 43a2c7078d88d83b3710b71f4182483c0de56f10..2aa634c7002703b61bdd78621fe057034c287145 100644

--- a/webrtc/pc/peerconnection.h

+++ b/webrtc/pc/peerconnection.h

@@ -205,7 +205,8 @@ class PeerConnection : public PeerConnectionInterface,

// Implements IceObserver

void OnIceConnectionStateChange(IceConnectionState new_state) override;

void OnIceGatheringChange(IceGatheringState new_state) override;

- void OnIceCandidate(const IceCandidateInterface* candidate) override;

+ void OnIceCandidate(

+ std::unique_ptr<IceCandidateInterface> candidate) override;

void OnIceCandidatesRemoved(

const std::vector<cricket::Candidate>& candidates) override;

void OnIceConnectionReceivingChange(bool receiving) override;

« no previous file with comments | « no previous file | webrtc/pc/peerconnection.cc » ('j') | no next file with comments »