Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Side by Side Diff: webrtc/pc/peerconnection.h

Issue 2748253003: Pass ownership of candidate to PeerConnection::OnIceCandidate (Closed)
Patch Set: Pass ownership through std::unique_ptr Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/pc/peerconnection.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 187 matching lines...) Expand 10 before | Expand all | Expand 10 after
198 void DestroyReceiver(const std::string& track_id); 198 void DestroyReceiver(const std::string& track_id);
199 void DestroyAudioSender(MediaStreamInterface* stream, 199 void DestroyAudioSender(MediaStreamInterface* stream,
200 AudioTrackInterface* audio_track, 200 AudioTrackInterface* audio_track,
201 uint32_t ssrc); 201 uint32_t ssrc);
202 void DestroyVideoSender(MediaStreamInterface* stream, 202 void DestroyVideoSender(MediaStreamInterface* stream,
203 VideoTrackInterface* video_track); 203 VideoTrackInterface* video_track);
204 204
205 // Implements IceObserver 205 // Implements IceObserver
206 void OnIceConnectionStateChange(IceConnectionState new_state) override; 206 void OnIceConnectionStateChange(IceConnectionState new_state) override;
207 void OnIceGatheringChange(IceGatheringState new_state) override; 207 void OnIceGatheringChange(IceGatheringState new_state) override;
208 void OnIceCandidate(const IceCandidateInterface* candidate) override; 208 void OnIceCandidate(
209 std::unique_ptr<IceCandidateInterface> candidate) override;
209 void OnIceCandidatesRemoved( 210 void OnIceCandidatesRemoved(
210 const std::vector<cricket::Candidate>& candidates) override; 211 const std::vector<cricket::Candidate>& candidates) override;
211 void OnIceConnectionReceivingChange(bool receiving) override; 212 void OnIceConnectionReceivingChange(bool receiving) override;
212 213
213 // Signals from WebRtcSession. 214 // Signals from WebRtcSession.
214 void OnSessionStateChange(WebRtcSession* session, WebRtcSession::State state); 215 void OnSessionStateChange(WebRtcSession* session, WebRtcSession::State state);
215 void ChangeSignalingState(SignalingState signaling_state); 216 void ChangeSignalingState(SignalingState signaling_state);
216 217
217 // Signals from MediaStreamObserver. 218 // Signals from MediaStreamObserver.
218 void OnAudioTrackAdded(AudioTrackInterface* track, 219 void OnAudioTrackAdded(AudioTrackInterface* track,
(...skipping 227 matching lines...) Expand 10 before | Expand all | Expand 10 after
446 rtc::scoped_refptr<RtpReceiverProxyWithInternal<RtpReceiverInternal>>> 447 rtc::scoped_refptr<RtpReceiverProxyWithInternal<RtpReceiverInternal>>>
447 receivers_; 448 receivers_;
448 std::unique_ptr<WebRtcSession> session_; 449 std::unique_ptr<WebRtcSession> session_;
449 std::unique_ptr<StatsCollector> stats_; 450 std::unique_ptr<StatsCollector> stats_;
450 rtc::scoped_refptr<RTCStatsCollector> stats_collector_; 451 rtc::scoped_refptr<RTCStatsCollector> stats_collector_;
451 }; 452 };
452 453
453 } // namespace webrtc 454 } // namespace webrtc
454 455
455 #endif // WEBRTC_PC_PEERCONNECTION_H_ 456 #endif // WEBRTC_PC_PEERCONNECTION_H_
OLDNEW
« no previous file with comments | « no previous file | webrtc/pc/peerconnection.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698