Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2748183006: Delete unused test code in modules/video_coding/test/ (Closed)

Created:
3 years, 9 months ago by tommi
Modified:
3 years, 9 months ago
Reviewers:
stefan-webrtc, mflodman
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete unused test code in modules/video_coding/test/ BUG=none Review-Url: https://codereview.webrtc.org/2748183006 Cr-Commit-Position: refs/heads/master@{#17295} Committed: https://chromium.googlesource.com/external/webrtc/+/533aedc492c429ec4fcb2fdc4e4a7498d61b69b8

Patch Set 1 #

Patch Set 2 : Make NullEvent private so that more tests won't start using it. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1633 lines) Patch
D webrtc/modules/video_coding/test/plotJitterEstimate.m View 1 chunk +0 lines, -52 lines 0 comments Download
D webrtc/modules/video_coding/test/plotReceiveTrace.m View 1 chunk +0 lines, -213 lines 0 comments Download
D webrtc/modules/video_coding/test/plotTimingTest.m View 1 chunk +0 lines, -62 lines 0 comments Download
D webrtc/modules/video_coding/test/receiver_tests.h View 1 chunk +0 lines, -42 lines 0 comments Download
D webrtc/modules/video_coding/test/rtp_player.h View 1 chunk +0 lines, -100 lines 0 comments Download
D webrtc/modules/video_coding/test/rtp_player.cc View 1 chunk +0 lines, -493 lines 0 comments Download
M webrtc/modules/video_coding/test/stream_generator.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/test/stream_generator.cc View 1 chunk +0 lines, -1 line 0 comments Download
D webrtc/modules/video_coding/test/subfigure.m View 1 chunk +0 lines, -30 lines 0 comments Download
M webrtc/modules/video_coding/test/test_util.h View 1 1 chunk +9 lines, -55 lines 0 comments Download
D webrtc/modules/video_coding/test/test_util.cc View 1 chunk +0 lines, -142 lines 0 comments Download
D webrtc/modules/video_coding/test/tester_main.cc View 1 chunk +0 lines, -78 lines 0 comments Download
D webrtc/modules/video_coding/test/vcm_payload_sink_factory.h View 1 chunk +0 lines, -70 lines 0 comments Download
D webrtc/modules/video_coding/test/vcm_payload_sink_factory.cc View 1 chunk +0 lines, -202 lines 0 comments Download
D webrtc/modules/video_coding/test/video_rtp_play.cc View 1 chunk +0 lines, -90 lines 0 comments Download
M webrtc/modules/video_coding/timing_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/video_sender_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (10 generated)
tommi
magnus, stefan - I stumbled upon this code and was going to fix it when ...
3 years, 9 months ago (2017-03-16 21:59:34 UTC) #4
tommi
Make NullEvent private so that more tests won't start using it.
3 years, 9 months ago (2017-03-16 22:23:33 UTC) #5
stefan-webrtc
lgtm
3 years, 9 months ago (2017-03-17 14:49:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2748183006/20001
3 years, 9 months ago (2017-03-17 15:07:01 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 15:11:15 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/533aedc492c429ec4fcb2fdc4...

Powered by Google App Engine
This is Rietveld 408576698