Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2748123002: Better handling of error condition in MediaCodecVideoEncoder. (Closed)

Created:
3 years, 9 months ago by sakal
Modified:
3 years, 9 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Better handling of error condition in MediaCodecVideoEncoder. BUG=b/36082499 Review-Url: https://codereview.webrtc.org/2748123002 Cr-Commit-Position: refs/heads/master@{#17246} Committed: https://chromium.googlesource.com/external/webrtc/+/996a83c4c830ee2b4966c0f84a8b0201d67563fb

Patch Set 1 : Better handling of error condition in MediaCodecVideoEncoder. #

Total comments: 2

Patch Set 2 : Change error message. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -28 lines) Patch
M webrtc/base/java/src/org/webrtc/ThreadUtils.java View 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/sdk/android/api/org/webrtc/MediaCodecVideoEncoder.java View 1 4 chunks +54 lines, -22 lines 0 comments Download
M webrtc/sdk/android/src/jni/androidmediaencoder_jni.cc View 5 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
sakal
PTAL
3 years, 9 months ago (2017-03-14 13:48:47 UTC) #3
magjed_webrtc
lgtm https://codereview.webrtc.org/2748123002/diff/20001/webrtc/sdk/android/api/org/webrtc/MediaCodecVideoEncoder.java File webrtc/sdk/android/api/org/webrtc/MediaCodecVideoEncoder.java (right): https://codereview.webrtc.org/2748123002/diff/20001/webrtc/sdk/android/api/org/webrtc/MediaCodecVideoEncoder.java#newcode611 webrtc/sdk/android/api/org/webrtc/MediaCodecVideoEncoder.java:611: throw new RuntimeException("Stopping encoder hang."); I like the ...
3 years, 9 months ago (2017-03-15 12:15:07 UTC) #4
sakal
https://codereview.webrtc.org/2748123002/diff/20001/webrtc/sdk/android/api/org/webrtc/MediaCodecVideoEncoder.java File webrtc/sdk/android/api/org/webrtc/MediaCodecVideoEncoder.java (right): https://codereview.webrtc.org/2748123002/diff/20001/webrtc/sdk/android/api/org/webrtc/MediaCodecVideoEncoder.java#newcode611 webrtc/sdk/android/api/org/webrtc/MediaCodecVideoEncoder.java:611: throw new RuntimeException("Stopping encoder hang."); On 2017/03/15 12:15:07, magjed_webrtc ...
3 years, 9 months ago (2017-03-15 12:20:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2748123002/60001
3 years, 9 months ago (2017-03-15 12:20:21 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 12:53:17 UTC) #12
Message was sent while issue was closed. 
Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/996a83c4c830ee2b4966c0f84...

Powered by Google App Engine
This is Rietveld 408576698