third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngineSpacing.cpp - Issue 2748103015: Replace ASSERT with DCHECK in core/layout/<sub dirs>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngineSpacing.cpp

Issue 2748103015: Replace ASSERT with DCHECK in core/layout/<sub dirs> (Closed)

Patch Set: Rebase with latest Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngineBaseline.cpp ('k') | third_party/WebKit/Source/core/layout/svg/SVGTextQuery.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngineSpacing.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngineSpacing.cpp b/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngineSpacing.cpp

index 7bd3564d79932540b3754786897a14485afca894..c9426d3848f7e5e0bb8baaa12fc8b3eafbd00bae 100644

--- a/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngineSpacing.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngineSpacing.cpp

@@ -27,7 +27,7 @@ namespace blink {

SVGTextLayoutEngineSpacing::SVGTextLayoutEngineSpacing(const Font& font,

float effectiveZoom)

: m_font(font), m_lastCharacter(0), m_effectiveZoom(effectiveZoom) {

- ASSERT(m_effectiveZoom);

+ DCHECK(m_effectiveZoom);

}

float SVGTextLayoutEngineSpacing::calculateCSSSpacing(UChar currentCharacter) {