third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.cpp - Issue 2748103015: Replace ASSERT with DCHECK in core/layout/<sub dirs>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.cpp

Issue 2748103015: Replace ASSERT with DCHECK in core/layout/<sub dirs> (Closed)

Patch Set: Rebase with latest Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/svg/SVGTextChunkBuilder.cpp ('k') | third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.cpp b/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.cpp

index 36f2aab9cf62db65e9e975960539798f9953eb41..11ec151fa171ab27edcf4e949c1211a9daafba7d 100644

--- a/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.cpp

@@ -100,11 +100,11 @@ static inline unsigned countCharactersInTextNode(

static SVGTextPositioningElement* positioningElementFromLayoutObject(

LayoutObject& layoutObject) {

- ASSERT(layoutObject.isSVGText() || layoutObject.isSVGInline());

+ DCHECK(layoutObject.isSVGText() || layoutObject.isSVGInline());

Node* node = layoutObject.node();

- ASSERT(node);

- ASSERT(node->isSVGElement());

+ DCHECK(node);

+ DCHECK(node->isSVGElement());

return isSVGTextPositioningElement(*node) ? toSVGTextPositioningElement(node)

: nullptr;

@@ -112,7 +112,7 @@ static SVGTextPositioningElement* positioningElementFromLayoutObject(

void SVGTextLayoutAttributesBuilder::collectTextPositioningElements(

LayoutBoxModelObject& start) {

- ASSERT(!start.isSVGText() || m_textPositions.isEmpty());

+ DCHECK(!start.isSVGText() || m_textPositions.isEmpty());

SVGTextPositioningElement* element =

positioningElementFromLayoutObject(start);

unsigned atPosition = m_textPositions.size();

@@ -138,7 +138,7 @@ void SVGTextLayoutAttributesBuilder::collectTextPositioningElements(

// Compute the length of the subtree after all children have been visited.

TextPosition& position = m_textPositions[atPosition];

- ASSERT(!position.length);

+ DCHECK(!position.length);

position.length = m_characterCount - position.start;

}