third_party/WebKit/Source/core/layout/compositing/GraphicsLayerUpdater.cpp - Issue 2748103015: Replace ASSERT with DCHECK in core/layout/<sub dirs>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/GraphicsLayerUpdater.cpp

Issue 2748103015: Replace ASSERT with DCHECK in core/layout/<sub dirs> (Closed)

Patch Set: Rebase with latest Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp ('k') | third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/compositing/GraphicsLayerUpdater.cpp

diff --git a/third_party/WebKit/Source/core/layout/compositing/GraphicsLayerUpdater.cpp b/third_party/WebKit/Source/core/layout/compositing/GraphicsLayerUpdater.cpp

index 66172b83c5ce8126e3a17fc1d5428ed415440105..206a380497331df2363912b582c1899ed2320b04 100644

--- a/third_party/WebKit/Source/core/layout/compositing/GraphicsLayerUpdater.cpp

+++ b/third_party/WebKit/Source/core/layout/compositing/GraphicsLayerUpdater.cpp

@@ -100,8 +100,8 @@ void GraphicsLayerUpdater::updateRecursive(

if (updateType == ForceUpdate || mapping->needsGraphicsLayerUpdate()) {

const PaintLayer* compositingContainer =

context.compositingContainer(layer);

- ASSERT(compositingContainer ==

- layer.enclosingLayerWithCompositedLayerMapping(ExcludeSelf));

+ DCHECK_EQ(compositingContainer,

+ layer.enclosingLayerWithCompositedLayerMapping(ExcludeSelf));

if (mapping->updateGraphicsLayerConfiguration())

m_needsRebuildTree = true;