Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2747403002:
Fix crash in vie_encoder when encoder configure fails (Closed)
DescriptionFix crash in vie_encoder when encoder configure fails
Bad changes are from CL 2745523002.
These changes were originally done by Sprang@. Sometimes, when encoder is failed to be configured on release build it causes a crash at vie_encoder.cc:451. That changes look like they are not important to other changes. This CL is simply reverting them.
BUG=chromium:701526
Review-Url: https://codereview.webrtc.org/2747403002
Cr-Commit-Position: refs/heads/master@{#17241}
Committed: https://chromium.googlesource.com/external/webrtc/+/35b7de480b1ae796e232fd862e4fa3e6704dca0e
Patch Set 1 #
Total comments: 2
Patch Set 2 : Fix spacing #Messages
Total messages: 18 (13 generated)
The CQ bit was checked by ilnik@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Description was changed from ========== Revert accidental changes from CL 2745523002 These changes were not done by me, but were accidentally included in my CL. This causes crashes when encoder fails to be configured. BUG=chrome:701526 ========== to ========== Revert bad changes from CL 2745523002 These changes were originally done by Sprang@. Sometimes, when encoder is failed to be configured on release build it causes a crash at vie_encoder.cc:451. BUG=chrome:701526 ==========
ilnik@webrtc.org changed reviewers: + asapersson@webrtc.org, stefan@webrtc.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Revert bad changes from CL 2745523002 These changes were originally done by Sprang@. Sometimes, when encoder is failed to be configured on release build it causes a crash at vie_encoder.cc:451. BUG=chrome:701526 ========== to ========== Revert bad changes from CL 2745523002 These changes were originally done by Sprang@. Sometimes, when encoder is failed to be configured on release build it causes a crash at vie_encoder.cc:451. BUG=chromium:701526 ==========
Description was changed from ========== Revert bad changes from CL 2745523002 These changes were originally done by Sprang@. Sometimes, when encoder is failed to be configured on release build it causes a crash at vie_encoder.cc:451. BUG=chromium:701526 ========== to ========== Fix crash in vie_encoder then encoder configure fails Bad changes are from CL 2745523002. These changes were originally done by Sprang@. Sometimes, when encoder is failed to be configured on release build it causes a crash at vie_encoder.cc:451. That changes look like they are not important to other changes. This CL is simply reverting them. BUG=chromium:701526 ==========
Description was changed from ========== Fix crash in vie_encoder then encoder configure fails Bad changes are from CL 2745523002. These changes were originally done by Sprang@. Sometimes, when encoder is failed to be configured on release build it causes a crash at vie_encoder.cc:451. That changes look like they are not important to other changes. This CL is simply reverting them. BUG=chromium:701526 ========== to ========== Fix crash in vie_encoder when encoder configure fails Bad changes are from CL 2745523002. These changes were originally done by Sprang@. Sometimes, when encoder is failed to be configured on release build it causes a crash at vie_encoder.cc:451. That changes look like they are not important to other changes. This CL is simply reverting them. BUG=chromium:701526 ==========
lgtm https://codereview.webrtc.org/2747403002/diff/1/webrtc/video/vie_encoder.cc File webrtc/video/vie_encoder.cc (right): https://codereview.webrtc.org/2747403002/diff/1/webrtc/video/vie_encoder.cc#n... webrtc/video/vie_encoder.cc:445: bitrate_observer_); nit: check spacing
https://codereview.webrtc.org/2747403002/diff/1/webrtc/video/vie_encoder.cc File webrtc/video/vie_encoder.cc (right): https://codereview.webrtc.org/2747403002/diff/1/webrtc/video/vie_encoder.cc#n... webrtc/video/vie_encoder.cc:445: bitrate_observer_); On 2017/03/15 11:03:01, åsapersson wrote: > nit: check spacing Done.
The CQ bit was checked by ilnik@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from asapersson@webrtc.org Link to the patchset: https://codereview.webrtc.org/2747403002/#ps20001 (title: "Fix spacing")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489575902595680,
"parent_rev": "7f704df74c62a121b8db9ffc2dc3aa316f4d86cf", "commit_rev":
"35b7de480b1ae796e232fd862e4fa3e6704dca0e"}
Message was sent while issue was closed.
Description was changed from ========== Fix crash in vie_encoder when encoder configure fails Bad changes are from CL 2745523002. These changes were originally done by Sprang@. Sometimes, when encoder is failed to be configured on release build it causes a crash at vie_encoder.cc:451. That changes look like they are not important to other changes. This CL is simply reverting them. BUG=chromium:701526 ========== to ========== Fix crash in vie_encoder when encoder configure fails Bad changes are from CL 2745523002. These changes were originally done by Sprang@. Sometimes, when encoder is failed to be configured on release build it causes a crash at vie_encoder.cc:451. That changes look like they are not important to other changes. This CL is simply reverting them. BUG=chromium:701526 Review-Url: https://codereview.webrtc.org/2747403002 Cr-Commit-Position: refs/heads/master@{#17241} Committed: https://chromium.googlesource.com/external/webrtc/+/35b7de480b1ae796e232fd862... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/webrtc/+/35b7de480b1ae796e232fd862... |
