Delete FilesystemInterface::CopyFile.

Delete FilesystemInterface::CopyFile.

Only use of this method was to implement the cross-device case of
MoveFile on unix systems.

In turn, only use of the MoveFile method is in
FileRotatingStream::RotateFiles. Since file rotation should never
involve any copying of log data, the MoveFile fallback to copying can
be deleted.

BUG=webrtc:6424
Review-Url: https://codereview.webrtc.org/2747373003
Cr-Commit-Position: refs/heads/master@{#17364}
Committed: https://chromium.googlesource.com/external/webrtc/+/7b3ce5b87239c50bf6a3f1a36099c32176bbe45e

[nisse-webrtc, 2017-03-15 09:01:38]

nisse@webrtc.org changed reviewers:
+ pthatcher@webrtc.org, tkchin@webrtc.org

[nisse-webrtc, 2017-03-15 09:01:38]

PTAL. This could affect log rotation for android devices, but I wouldn't expect
them to depend on the CopyFile fallback.

[pthatcher1, 2017-03-15 15:38:22]

lgtm

[tkchin_webrtc, 2017-03-16 16:09:49]

Description was changed from

==========
Delete FilesystemInterface::CopyFile.

Only use of this method was to implement the cross-device case of
MoveFile on unix systems.

In turn, only use of the MoveFile method is in
FileRotatingStream::RotateFiles. Since file rotation should never
involve any copying of log data, the MoveFile fallback to copying can
be deleted.

BUG=webrtc:6424
==========

to

==========
Delete FilesystemInterface::CopyFile.

Only use of this method was to implement the cross-device case of
MoveFile on unix systems.

In turn, only use of the MoveFile method is in
FileRotatingStream::RotateFiles. Since file rotation should never
involve any copying of log data, the MoveFile fallback to copying can
be deleted.

BUG=webrtc:6424
==========

[tkchin_webrtc, 2017-03-16 16:09:50]

tkchin@webrtc.org changed reviewers:
+ glaznev@webrtc.org

[tkchin_webrtc, 2017-03-16 16:11:31]

On 2017/03/15 15:38:22, pthatcher1 wrote:
> lgtm

lgtm but Alex should stamp for Android

[nisse-webrtc, 2017-03-23 15:36:06]

On 2017/03/16 16:11:31, tkchin_webrtc wrote:
> On 2017/03/15 15:38:22, pthatcher1 wrote:
> > lgtm
> 
> lgtm but Alex should stamp for Android

Alex, ping?

[AlexG, 2017-03-23 17:08:07]

lgtm

[nisse-webrtc, 2017-03-23 17:22:04]

The CQ bit was checked by nisse@webrtc.org

[commit-bot: I haz the power, 2017-03-23 17:22:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-23 17:54:17]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490289724219060, "parent_rev":
"1523865cc31153b7f381901c11e385a49a7e1842", "commit_rev":
"7b3ce5b87239c50bf6a3f1a36099c32176bbe45e"}

[commit-bot: I haz the power, 2017-03-23 17:54:20]

Description was changed from

==========
Delete FilesystemInterface::CopyFile.

Only use of this method was to implement the cross-device case of
MoveFile on unix systems.

In turn, only use of the MoveFile method is in
FileRotatingStream::RotateFiles. Since file rotation should never
involve any copying of log data, the MoveFile fallback to copying can
be deleted.

BUG=webrtc:6424
==========

to

==========
Delete FilesystemInterface::CopyFile.

Only use of this method was to implement the cross-device case of
MoveFile on unix systems.

In turn, only use of the MoveFile method is in
FileRotatingStream::RotateFiles. Since file rotation should never
involve any copying of log data, the MoveFile fallback to copying can
be deleted.

BUG=webrtc:6424

Review-Url: https://codereview.webrtc.org/2747373003
Cr-Commit-Position: refs/heads/master@{#17364}
Committed:
https://chromium.googlesource.com/external/webrtc/+/7b3ce5b87239c50bf6a3f1a36...
==========

[commit-bot: I haz the power, 2017-03-23 17:54:21]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/7b3ce5b87239c50bf6a3f1a36...