Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issue 2746763002: Revert to allowing only 1 unsignaled receive stream for audio. (Closed)

Created:
3 years, 9 months ago by the sun
Modified:
3 years, 9 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, noahric-google
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert to allowing only 1 unsignaled receive stream for audio. Reason to go back is that we may end up with a bunch of streams that are never cleaned up and consume resources. BUG=webrtc:7175 , b/35863246 Review-Url: https://codereview.webrtc.org/2746763002 Cr-Commit-Position: refs/heads/master@{#17210} Committed: https://chromium.googlesource.com/external/webrtc/+/ebb349d7c936b785b50913456b19497a05a3b0d9

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -16 lines) Patch
M webrtc/media/engine/webrtcvoiceengine.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/media/engine/webrtcvoiceengine_unittest.cc View 1 2 6 chunks +29 lines, -15 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
the sun
3 years, 9 months ago (2017-03-12 21:23:08 UTC) #2
tommi
lgtm - can you include info on why? (even in the bug)
3 years, 9 months ago (2017-03-12 23:13:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2746763002/1
3 years, 9 months ago (2017-03-13 09:10:57 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_rel/builds/24101)
3 years, 9 months ago (2017-03-13 09:25:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2746763002/40001
3 years, 9 months ago (2017-03-13 12:25:54 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 12:46:21 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/ebb349d7c936b785b50913456...

Powered by Google App Engine
This is Rietveld 408576698