Delete support for sending RTCP RPSI and SLI messages.

Delete support for sending RTCP RPSI and SLI messages.

BUG=webrtc:7338
Review-Url: https://codereview.webrtc.org/2746413003
Cr-Commit-Position: refs/heads/master@{#17229}
Committed: https://chromium.googlesource.com/external/webrtc/+/cd386eb13fdc2420a0e6811ec2beca2d553f2166

[nisse-webrtc, 2017-03-14 12:52:16]

nisse@webrtc.org changed reviewers:
+ danilchap@webrtc.org, stefan@webrtc.org

[nisse-webrtc, 2017-03-14 12:52:16]

PTAL. Extracted from https://codereview.webrtc.org/2742383004/, to review and
land things piecewise.

[danilchap, 2017-03-14 13:31:47]

lgtm

https://codereview.webrtc.org/2746413003/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_sender.cc (right):

https://codereview.webrtc.org/2746413003/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_sender.cc:141: const uint64_t picture_id_;
may be remove this field too in this CL

https://codereview.webrtc.org/2746413003/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_sender.h (right):

https://codereview.webrtc.org/2746413003/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_sender.h:116: uint64_t pictureID = 0);
may be remove this parameter too

https://codereview.webrtc.org/2746413003/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_sender.h:122: uint64_t pictureID = 0);
may be remove this parameter too

[nisse-webrtc, 2017-03-14 13:41:09]

https://codereview.webrtc.org/2746413003/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_sender.cc (right):

https://codereview.webrtc.org/2746413003/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_sender.cc:141: const uint64_t picture_id_;
On 2017/03/14 13:31:46, danilchap wrote:
> may be remove this field too in this CL

Done.

https://codereview.webrtc.org/2746413003/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_sender.h (right):

https://codereview.webrtc.org/2746413003/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_sender.h:116: uint64_t pictureID = 0);
On 2017/03/14 13:31:47, danilchap wrote:
> may be remove this parameter too

Done.

https://codereview.webrtc.org/2746413003/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_sender.h:122: uint64_t pictureID = 0);
On 2017/03/14 13:31:46, danilchap wrote:
> may be remove this parameter too

Done.

[nisse-webrtc, 2017-03-14 15:02:12]

The CQ bit was checked by nisse@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 15:02:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-14 15:34:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 15:34:05]

Dry run: This issue passed the CQ dry run.

[stefan-webrtc, 2017-03-14 15:52:07]

lgtm

[nisse-webrtc, 2017-03-14 15:52:33]

The CQ bit was checked by nisse@webrtc.org

[nisse-webrtc, 2017-03-14 15:52:33]

The patchset sent to the CQ was uploaded after l-g-t-m from danilchap@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2746413003/#ps20001 (title:
"Delete RtcpContext::picture_id_, and related arguments.")

[commit-bot: I haz the power, 2017-03-14 15:52:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-14 15:54:44]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489506753457370,
"parent_rev": "0a735643388622494cd59720a40b51899985be99", "commit_rev":
"cd386eb13fdc2420a0e6811ec2beca2d553f2166"}

[commit-bot: I haz the power, 2017-03-14 15:54:48]

Description was changed from

==========
Delete support for sending RTCP RPSI and SLI messages.

BUG=webrtc:7338
==========

to

==========
Delete support for sending RTCP RPSI and SLI messages.

BUG=webrtc:7338

Review-Url: https://codereview.webrtc.org/2746413003
Cr-Commit-Position: refs/heads/master@{#17229}
Committed:
https://chromium.googlesource.com/external/webrtc/+/cd386eb13fdc2420a0e6811ec...
==========

[commit-bot: I haz the power, 2017-03-14 15:54:49]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/cd386eb13fdc2420a0e6811ec...