Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1389)

Issue 2746403002: Add low_bandwidth_audio_test to default build (Closed)

Created:
3 years, 9 months ago by oprypin_webrtc
Modified:
3 years, 9 months ago
Reviewers:
ossu, kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, tlegrand-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add low_bandwidth_audio_test to default build https://codereview.webrtc.org/2717683002/ added a placeholder binary but it still needs to be included in the default build before enabling it on bots. BUG=webrtc:7229 Review-Url: https://codereview.webrtc.org/2746403002 Cr-Commit-Position: refs/heads/master@{#17302} Committed: https://chromium.googlesource.com/external/webrtc/+/5e1ca78705f9ac3319fdfc3084aefdea3ed6e675

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M webrtc/audio/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
oprypin_webrtc
3 years, 9 months ago (2017-03-14 10:39:10 UTC) #5
kjellander_webrtc
lgtm
3 years, 9 months ago (2017-03-14 11:11:14 UTC) #8
oprypin_webrtc
ossu@, please review this change.
3 years, 9 months ago (2017-03-17 09:15:21 UTC) #9
kjellander_webrtc
On 2017/03/17 09:15:21, oprypin_webrtc wrote: > ossu@, please review this change. Not strictly necessary, * ...
3 years, 9 months ago (2017-03-17 09:24:44 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2746403002/1
3 years, 9 months ago (2017-03-20 08:44:50 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-20 09:06:22 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/5e1ca78705f9ac3319fdfc308...

Powered by Google App Engine
This is Rietveld 408576698