Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 2746393003: RTCStatsCollector: Remove closed channels from opened set. (Closed)

Created:
3 years, 9 months ago by hbos
Modified:
3 years, 9 months ago
Reviewers:
guidou
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

RTCStatsCollector: Remove closed channels from opened set. This is a problem if a data channel is re-opened or a new data channel occupies the same space in memory as a previously closed data channel. Unittest updated to cover this (failed before fix, now passes). BUG=webrtc:7181 Review-Url: https://codereview.webrtc.org/2746393003 Cr-Commit-Position: refs/heads/master@{#17304} Committed: https://chromium.googlesource.com/external/webrtc/+/5bf9def61b916477898dd1d33f0f34b2c8df7056

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -3 lines) Patch
M webrtc/pc/rtcstatscollector.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M webrtc/pc/rtcstatscollector_unittest.cc View 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
hbos
Please take a look, guidou.
3 years, 9 months ago (2017-03-14 11:50:49 UTC) #4
guidou
lgtm
3 years, 9 months ago (2017-03-20 09:48:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2746393003/1
3 years, 9 months ago (2017-03-20 09:50:59 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-20 10:14:18 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/5bf9def61b916477898dd1d33...

Powered by Google App Engine
This is Rietveld 408576698