Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(894)

Unified Diff: webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl_unittest.cc

Issue 2746333009: OnReceivedUplinkPacketLossFraction() receives [const rtc::Optional<float>&] (Closed)
Patch Set: Rebased Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl_unittest.cc
diff --git a/webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl_unittest.cc b/webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl_unittest.cc
index db2a466c436fdafcfceaf82fda47a9b517b41f3b..98a641183c38d06aef58666a49aa93f61c02ad05 100644
--- a/webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl_unittest.cc
+++ b/webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl_unittest.cc
@@ -120,9 +120,9 @@ TEST(AudioNetworkAdaptorImplTest,
TEST(AudioNetworkAdaptorImplTest,
UpdateNetworkMetricsIsCalledOnSetUplinkPacketLossFraction) {
auto states = CreateAudioNetworkAdaptor();
- constexpr float kPacketLoss = 0.7f;
+ const auto kPacketLoss = rtc::Optional<float>(0.7f);
Controller::NetworkMetrics check;
- check.uplink_packet_loss_fraction = rtc::Optional<float>(kPacketLoss);
+ check.uplink_packet_loss_fraction = kPacketLoss;
SetExpectCallToUpdateNetworkMetrics(states.mock_controllers, check);
states.audio_network_adaptor->SetUplinkPacketLossFraction(kPacketLoss);
}
@@ -185,7 +185,7 @@ TEST(AudioNetworkAdaptorImplTest,
auto states = CreateAudioNetworkAdaptor();
constexpr int kBandwidth = 16000;
- constexpr float kPacketLoss = 0.7f;
+ const auto kPacketLoss = rtc::Optional<float>(0.7f);
constexpr int kRtt = 100;
constexpr int kTargetAudioBitrate = 15000;
constexpr size_t kOverhead = 64;
@@ -200,7 +200,7 @@ TEST(AudioNetworkAdaptorImplTest,
states.simulated_clock->AdvanceTimeMilliseconds(100);
timestamp_check += 100;
- check.uplink_packet_loss_fraction = rtc::Optional<float>(kPacketLoss);
+ check.uplink_packet_loss_fraction = kPacketLoss;
EXPECT_CALL(*states.mock_debug_dump_writer,
DumpNetworkMetrics(NetworkMetricsIs(check), timestamp_check));
states.audio_network_adaptor->SetUplinkPacketLossFraction(kPacketLoss);

Powered by Google App Engine
This is Rietveld 408576698