webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl.cc - Issue 2746333009: OnReceivedUplinkPacketLossFraction() receives [const rtc::Optional<float>&]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl.cc

Issue 2746333009: OnReceivedUplinkPacketLossFraction() receives [const rtc::Optional<float>&] (Closed)

Patch Set: Rebased Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl.h ('k') | webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl.cc

diff --git a/webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl.cc b/webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl.cc

index 612d2d35cc8ece00055ff9eb2c2faf4f11a0e46d..2bdce3fe3babbe51eb0894803f3622f1c7c13775 100644

--- a/webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl.cc

+++ b/webrtc/modules/audio_coding/audio_network_adaptor/audio_network_adaptor_impl.cc

@@ -57,14 +57,12 @@ void AudioNetworkAdaptorImpl::SetUplinkBandwidth(int uplink_bandwidth_bps) {

}

void AudioNetworkAdaptorImpl::SetUplinkPacketLossFraction(

- float uplink_packet_loss_fraction) {

- last_metrics_.uplink_packet_loss_fraction =

- rtc::Optional<float>(uplink_packet_loss_fraction);

+ const rtc::Optional<float>& uplink_packet_loss_fraction) {

+ last_metrics_.uplink_packet_loss_fraction = uplink_packet_loss_fraction;

DumpNetworkMetrics();

Controller::NetworkMetrics network_metrics;

- network_metrics.uplink_packet_loss_fraction =

- rtc::Optional<float>(uplink_packet_loss_fraction);

+ network_metrics.uplink_packet_loss_fraction = uplink_packet_loss_fraction;

UpdateNetworkMetrics(network_metrics);

}