Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2745613002:
Add back method CongestionController::GetTransportFeedbackObserver. (Closed)
|
Created:
3 years, 9 months ago by nisse-webrtc Modified:
3 years, 9 months ago CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionAdd back method CongestionController::GetTransportFeedbackObserver.
This is a partial revert of https://codereview.webrtc.org/2725823002/,
to not break downstream applications.
BUG=webrtc:7058
TBR=stefan@webrtc.org
Review-Url: https://codereview.webrtc.org/2745613002
Cr-Commit-Position: refs/heads/master@{#17152}
Committed: https://chromium.googlesource.com/external/webrtc/+/d64862ac1b672b6e9fba25a1363208407b1cd4f4
Patch Set 1 #
Messages
Total messages: 22 (12 generated)
The CQ bit was checked by nisse@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
nisse@webrtc.org changed reviewers: + elad.alon@webrtc.org, stefan@webrtc.org, terelius@webrtc.org
We'll see if this solves the problem. If bots are happy, I'll land it soon, TBR:ing it if necessary. But it may have to wait until tomorrow morning.
lgtm
On 2017/03/09 17:03:18, elad.alon wrote: > lgtm I wonder though if it's not possible/better to get rid of this function-call in the affected projects instead?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by nisse@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
nisse@webrtc.org changed reviewers: + zhihuang@webrtc.org
Hi, I think this cl solves the problem, both regular bots anr linux_interla bot are green. But I'm leaving for the evening now.
On 2017/03/09 19:14:27, nisse-webrtc wrote: > Hi, I think this cl solves the problem, both regular bots anr linux_interla bot > are green. But I'm leaving for the evening now. lgtm. I just created a CL that do the same thing. :) https://codereview.webrtc.org/2741813002/
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/14670)
On 2017/03/09 17:15:00, elad.alon wrote: > On 2017/03/09 17:03:18, elad.alon wrote: > > lgtm > > I wonder though if it's not possible/better to get rid of this function-call in > the affected projects instead? Since you are changing the base class, we probably need to change the internal project and webrtc at the same time. One way to do this is creating a cherry pick CL that change the internal version of WebRTC and the related project at the same time. The public WebRTC will overwrite it eventually.
Description was changed from ========== Add back method CongestionController::GetTransportFeedbackObserver. This is a partial revert of https://codereview.webrtc.org/2725823002/, to not break downstream applications. BUG=webrtc:7058 ========== to ========== Add back method CongestionController::GetTransportFeedbackObserver. This is a partial revert of https://codereview.webrtc.org/2725823002/, to not break downstream applications. BUG=webrtc:7058 TBR=stefan@webrtc.org ==========
The CQ bit was checked by zhihuang@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1489088613090000, "parent_rev":
"98b654f579f442e39679fa3a15dbe3e6aaadfc89", "commit_rev":
"d64862ac1b672b6e9fba25a1363208407b1cd4f4"}
Message was sent while issue was closed.
Description was changed from ========== Add back method CongestionController::GetTransportFeedbackObserver. This is a partial revert of https://codereview.webrtc.org/2725823002/, to not break downstream applications. BUG=webrtc:7058 TBR=stefan@webrtc.org ========== to ========== Add back method CongestionController::GetTransportFeedbackObserver. This is a partial revert of https://codereview.webrtc.org/2725823002/, to not break downstream applications. BUG=webrtc:7058 TBR=stefan@webrtc.org Review-Url: https://codereview.webrtc.org/2745613002 Cr-Commit-Position: refs/heads/master@{#17152} Committed: https://chromium.googlesource.com/external/webrtc/+/d64862ac1b672b6e9fba25a13... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/d64862ac1b672b6e9fba25a13... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
