webrtc/modules/audio_coding/audio_network_adaptor/frame_length_controller.h - Issue 2745473003: Resolve cyclic dependency between audio network adaptor and event log api

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/audio_network_adaptor/frame_length_controller.h

Issue 2745473003: Resolve cyclic dependency between audio network adaptor and event log api (Closed)

Patch Set: Activated checks for rtc_event_log_api Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/logging/BUILD.gn ('K') | « webrtc/modules/audio_coding/audio_network_adaptor/fec_controller_rplr_based_unittest.cc ('k') | webrtc/modules/audio_coding/audio_network_adaptor/frame_length_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/audio_network_adaptor/frame_length_controller.h

diff --git a/webrtc/modules/audio_coding/audio_network_adaptor/frame_length_controller.h b/webrtc/modules/audio_coding/audio_network_adaptor/frame_length_controller.h

index 74cbb5638d7df61531b668e3bdbd67fa1a0fd935..458938271d8d5ead2a14f58eddce6c018aee43c3 100644

--- a/webrtc/modules/audio_coding/audio_network_adaptor/frame_length_controller.h

+++ b/webrtc/modules/audio_coding/audio_network_adaptor/frame_length_controller.h

@@ -54,14 +54,14 @@ class FrameLengthController final : public Controller {

void UpdateNetworkMetrics(const NetworkMetrics& network_metrics) override;

- void MakeDecision(AudioNetworkAdaptor::EncoderRuntimeConfig* config) override;

+ void MakeDecision(AudioEncoderRuntimeConfig* config) override;

private:

bool FrameLengthIncreasingDecision(

- const AudioNetworkAdaptor::EncoderRuntimeConfig& config) const;

+ const AudioEncoderRuntimeConfig& config) const;

bool FrameLengthDecreasingDecision(

- const AudioNetworkAdaptor::EncoderRuntimeConfig& config) const;

+ const AudioEncoderRuntimeConfig& config) const;

const Config config_;